Skip to content

[Enhancement] tweaks for better error handling - #5

Merged
kezhenxu94 merged 1 commit into
apache:masterfrom
tom-pytel:master
Dec 3, 2020
Merged

[Enhancement] tweaks for better error handling#5
kezhenxu94 merged 1 commit into
apache:masterfrom
tom-pytel:master

Conversation

@tom-pytel

Copy link
Copy Markdown
Contributor
  • Removed ContextManager.withSpanNoStop() to clean up interface since this was only meant to be used in plugins and so the plugins themselves should do this.
  • Changed ContextManager.withSpan() and .withSpanAsync() to not insert span as first argument but rather just pass the args through to allow more generalized use, for example ContextManager.withSpanAsync(user_defined_span, unsupported_async_URL_requester, requester_arg1, ...).
  • Reworked HttpPlugin:http.request() to better cover and handle error conditions, should be 100% covered now (before there was a range between span.async() and the callback where an unexpected error could cause the span to not be stopped).

@kezhenxu94kezhenxu94 added this to the 0.1.0 milestone Dec 2, 2020
@kezhenxu94kezhenxu94 added the enhancement New feature or request label Dec 2, 2020

@kezhenxu94kezhenxu94 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kezhenxu94
kezhenxu94 merged commit 92399c3 into apache:masterDec 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tom-pytel@kezhenxu94