Skip to content

test: set up Node version matrix to test different versions#8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wu-sheng merged 1 commit into from
Dec 4, 2020
Merged

test: set up Node version matrix to test different versions #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,6 +30,8 @@ jobs:
strategy:
matrix:
node-version: [ 10, 12, 14 ]
env:
SW_NODE_VERSION: ${{ matrix.node-version }}
steps:
- uses: actions/checkout@v2
with:
Expand Down
4 changes: 3 additions & 1 deletion tests/plugins/common/Dockerfile.agent
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,7 +13,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM node:12
ARG SW_NODE_VERSION

FROM node:${SW_NODE_VERSION}

ARG ROOT=.

Expand Down
2 changes: 2 additions & 0 deletions tests/plugins/common/base-compose.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,8 @@ services:
build:
context: ../../../
dockerfile: tests/plugins/common/Dockerfile.agent
args:
- SW_NODE_VERSION=${SW_NODE_VERSION:-latest}
environment:
SW_AGENT_COLLECTOR_BACKEND_SERVICES: collector:19876
networks:
Expand Down