SOLR-18357: Remove SolrTestCaseJ4 URL-allowlist system-property helpers by serhiy-bzhezytskyy · Pull Request #4790 · apache/solr

serhiy-bzhezytskyy · 2026-08-21T17:05:11Z

What

Removes the deprecated SolrTestCaseJ4.systemSetPropertyEnableUrlAllowList(boolean) and systemClearPropertySolrEnableUrlAllowList() methods. Both were deprecated since 9.0 (SOLR-17864) as backwards-compatibility shims only, with no replacement API — systemClearPropertySolrEnableUrlAllowList() was already an empty no-op.

Scope

Bigger than a single method: 15 call sites across 13 files (solr-core tests + 2 solr-test-framework base classes: BaseDistributedSearchTestCase, SolrTestCaseHS).

Migrated every systemSetPropertyEnableUrlAllowList(value) call to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, String.valueOf(value)) directly — the exact body of the removed setter.
Deleted every systemClearPropertySolrEnableUrlAllowList() call outright (it did nothing).
In BaseDistributedSearchTestCase, that left clearSolrEnableUrlUrlAllowList() as an empty @AfterClass method with no other callers, so the whole method (and its now-unused @AfterClass import) was removed rather than left as a hollow shell.
Dropped 8 @SuppressWarnings("deprecation") annotations across 4 test files that existed solely to cover these calls.

Verification

Full-repo ./gradlew compileTestJava (exit 0) — confirms zero remaining references anywhere in the tree.
Targeted test runs green across every touched test class (TestTolerantSearch, TestHealthCheckHandlerLegacyMode, DistributedDebugComponentTest, TestSmileRequest, TestJsonRequest, TestJsonFacetRefinement, TestJsonFacetErrors, TestJsonRangeFacets, TestJsonFacets, TestReplicationHandler, TestUserManagedReplicationWithAuth).

Changelog

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so a type: removed changelog entry is included.

AI-assisted (Claude Sonnet 5)

serhiy-bzhezytskyy · 2026-08-21T17:05:18Z

cc @epugh (deprecated it, SOLR-17864)

epugh

LGTM.. one spurious thought, is there any chance that some of these tests do NOT need this setting at all? Sometimes settings like this get copy/n/pasted over multiple tests.

serhiy-bzhezytskyy · 2026-08-22T06:47:21Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

epugh · 2026-08-22T10:29:38Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

Awesome. did dc21831e629 get pushed? I didn't see it in this PR...

serhiy-bzhezytskyy · 2026-08-22T10:39:32Z

Sorry, pushed.

@afterclass

…/systemClearPropertySolrEnableUrlAllowList Both methods were deprecated since 9.0 (SOLR-17864, Eric Pugh, 2025-09-28) as backwards-compatibility shims only, with no replacement API -- systemClearPropertySolrEnableUrlAllowList() was already an empty no-op. Migrated all 15 call sites across 13 files to call System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, ...) directly (the exact body of the removed setter). Calls to the no-op clear method were deleted outright rather than replaced with anything. In BaseDistributedSearchTestCase, this left clearSolrEnableUrlUrlAllowList() as an empty @afterclass method with no other callers, so the whole method (and its now-unused @afterclass import) was deleted rather than left as a hollow shell. Also dropped 8 @SuppressWarnings("deprecation") annotations across 4 files that existed solely to cover these calls. Verified with a full-repo ./gradlew compileTestJava (exit 0) plus targeted test runs across every touched test class.

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so this removal is a real API break for downstream test code -- warrants a changelog entry per the same standard applied to SOLR-18354/SOLR-18356 earlier in this batch.

…etErrors Eric asked whether some of the migrated URL-allowlist settings were copy-pasted without actually being needed. Checked all 13 files by verifying each one's actual code path into AllowListUrlChecker (explicit shards= param, SolrInstances distributed queries, or IndexFetcher replication) -- confirmed empirically by temporarily removing the setting and re-running the test to see it fail with a 403, one representative case per category (TestTolerantSearch, TestSmileRequest, TestHealthCheckHandlerLegacyMode). TestJsonFacetErrors was the one exception: its SolrInstances scaffolding (initServers(), the servers field, the null-guarded stop() in tearDown) has been dead code since the file's creation in SOLR-14348 (2020-03-23, split out of TestJsonFacets) -- initServers() is declared but never called by any of the 5 test methods, all of which are single-node error-validation checks. Removed the scaffolding along with the now-pointless allow-list setting; the class's actual purpose (facet API error handling) is untouched and needs no distributed servers.

…temSetPropertyEnableUrlAllowList Rebasing onto latest main pulled in solr/webapp (added by SOLR-8474 after this branch's original base), which still had one call to the now-removed systemSetPropertyEnableUrlAllowList(false). Migrated to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, "false") directly, the same pattern used at every other call site in this PR.

dsmiley · 2026-08-22T22:38:55Z

There's another PR that has stalled on the subject of ALLOW_PATHS in tests. I'm not sure if we should merge this right now, as it may delay that one? (not sure but just want to raise the risk/concern)

…eplicas() call solr:webapp wasn't covered by this PR's own migration sweep -- same recurring gap as SOLR-18390/apache#4778 and SOLR-18357/apache#4790. replicaCount() still called the now-removed getReplicas().size(); migrated to replicaStream().count() (cast to int, matching the method's return type), the same pattern used at every other call site in this PR.

…-allowlist-helpers

serhiy-bzhezytskyy · 2026-08-24T07:08:43Z

Checked -- #4215 (SOLR-18123) uses CoreContainer.ALLOW_PATHS_SYSPROP (filesystem path restrictions), a different mechanism from this PR's systemSetPropertyEnableUrlAllowList/systemClearPropertySolrEnableUrlAllowList (URL-allowlist). No file or symbol overlap. If anything, this PR does what you asked for on #4215 for a different property -- removes the base-class toggle-helper wrappers and inlines the one System.setProperty(...) call at its only remaining caller, instead of keeping ceremony in SolrTestCaseJ4.

dsmiley · 2026-08-25T03:03:04Z

Thanks for looking into that.

lots of conflicts to resolve and a changelog to remove but otherwise I approve

@afterclass

…-allowlist-helpers Resolves conflicts from SOLR-18354's ErrorLogMuter migration (main), which touched the same 4 files: kept both sides' imports (AllowListUrlChecker from this branch, ErrorLogMuter from main), and in the two @afterclass teardown methods that had both a now-dead resetExceptionIgnores() call (superseded by main's scoped try-with-resources ErrorLogMuter usage) and a now-dead systemClearPropertySolrEnableUrlAllowList() call (removed by this branch), dropped both -- neither has any remaining purpose.

…est-framework-only change

serhiy-bzhezytskyy · 2026-08-25T10:36:18Z

Both done -- rebased on main and resolved a real conflict from SOLR-18354's ErrorLogMuter migration (dead resetExceptionIgnores()/systemClearPropertySolrEnableUrlAllowList() calls in two @AfterClass teardowns, both superseded), and removed the changelog entry.

epugh · 2026-08-25T11:10:31Z

running CI and then will merge... thnaks @dsmiley for reviewing.

epugh · 2026-08-27T01:25:22Z

test passed locally

…rs (#4790) (cherry picked from commit 1869a60)

serhiy-bzhezytskyy · 2026-08-21T17:05:11Z

What

Removes the deprecated SolrTestCaseJ4.systemSetPropertyEnableUrlAllowList(boolean) and systemClearPropertySolrEnableUrlAllowList() methods. Both were deprecated since 9.0 (SOLR-17864) as backwards-compatibility shims only, with no replacement API — systemClearPropertySolrEnableUrlAllowList() was already an empty no-op.

Scope

Bigger than a single method: 15 call sites across 13 files (solr-core tests + 2 solr-test-framework base classes: BaseDistributedSearchTestCase, SolrTestCaseHS).

Migrated every systemSetPropertyEnableUrlAllowList(value) call to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, String.valueOf(value)) directly — the exact body of the removed setter.
Deleted every systemClearPropertySolrEnableUrlAllowList() call outright (it did nothing).
In BaseDistributedSearchTestCase, that left clearSolrEnableUrlUrlAllowList() as an empty @AfterClass method with no other callers, so the whole method (and its now-unused @AfterClass import) was removed rather than left as a hollow shell.
Dropped 8 @SuppressWarnings("deprecation") annotations across 4 test files that existed solely to cover these calls.

Verification

Full-repo ./gradlew compileTestJava (exit 0) — confirms zero remaining references anywhere in the tree.
Targeted test runs green across every touched test class (TestTolerantSearch, TestHealthCheckHandlerLegacyMode, DistributedDebugComponentTest, TestSmileRequest, TestJsonRequest, TestJsonFacetRefinement, TestJsonFacetErrors, TestJsonRangeFacets, TestJsonFacets, TestReplicationHandler, TestUserManagedReplicationWithAuth).

Changelog

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so a type: removed changelog entry is included.

AI-assisted (Claude Sonnet 5)

serhiy-bzhezytskyy · 2026-08-21T17:05:18Z

cc @epugh (deprecated it, SOLR-17864)

epugh

LGTM.. one spurious thought, is there any chance that some of these tests do NOT need this setting at all? Sometimes settings like this get copy/n/pasted over multiple tests.

serhiy-bzhezytskyy · 2026-08-22T06:47:21Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

epugh · 2026-08-22T10:29:38Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

Awesome. did dc21831e629 get pushed? I didn't see it in this PR...

serhiy-bzhezytskyy · 2026-08-22T10:39:32Z

Sorry, pushed.

@afterclass

…/systemClearPropertySolrEnableUrlAllowList Both methods were deprecated since 9.0 (SOLR-17864, Eric Pugh, 2025-09-28) as backwards-compatibility shims only, with no replacement API -- systemClearPropertySolrEnableUrlAllowList() was already an empty no-op. Migrated all 15 call sites across 13 files to call System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, ...) directly (the exact body of the removed setter). Calls to the no-op clear method were deleted outright rather than replaced with anything. In BaseDistributedSearchTestCase, this left clearSolrEnableUrlUrlAllowList() as an empty @afterclass method with no other callers, so the whole method (and its now-unused @afterclass import) was deleted rather than left as a hollow shell. Also dropped 8 @SuppressWarnings("deprecation") annotations across 4 files that existed solely to cover these calls. Verified with a full-repo ./gradlew compileTestJava (exit 0) plus targeted test runs across every touched test class.

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so this removal is a real API break for downstream test code -- warrants a changelog entry per the same standard applied to SOLR-18354/SOLR-18356 earlier in this batch.

…etErrors Eric asked whether some of the migrated URL-allowlist settings were copy-pasted without actually being needed. Checked all 13 files by verifying each one's actual code path into AllowListUrlChecker (explicit shards= param, SolrInstances distributed queries, or IndexFetcher replication) -- confirmed empirically by temporarily removing the setting and re-running the test to see it fail with a 403, one representative case per category (TestTolerantSearch, TestSmileRequest, TestHealthCheckHandlerLegacyMode). TestJsonFacetErrors was the one exception: its SolrInstances scaffolding (initServers(), the servers field, the null-guarded stop() in tearDown) has been dead code since the file's creation in SOLR-14348 (2020-03-23, split out of TestJsonFacets) -- initServers() is declared but never called by any of the 5 test methods, all of which are single-node error-validation checks. Removed the scaffolding along with the now-pointless allow-list setting; the class's actual purpose (facet API error handling) is untouched and needs no distributed servers.

…temSetPropertyEnableUrlAllowList Rebasing onto latest main pulled in solr/webapp (added by SOLR-8474 after this branch's original base), which still had one call to the now-removed systemSetPropertyEnableUrlAllowList(false). Migrated to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, "false") directly, the same pattern used at every other call site in this PR.

dsmiley · 2026-08-22T22:38:55Z

There's another PR that has stalled on the subject of ALLOW_PATHS in tests. I'm not sure if we should merge this right now, as it may delay that one? (not sure but just want to raise the risk/concern)

…eplicas() call solr:webapp wasn't covered by this PR's own migration sweep -- same recurring gap as SOLR-18390/apache#4778 and SOLR-18357/apache#4790. replicaCount() still called the now-removed getReplicas().size(); migrated to replicaStream().count() (cast to int, matching the method's return type), the same pattern used at every other call site in this PR.

…-allowlist-helpers

serhiy-bzhezytskyy · 2026-08-24T07:08:43Z

Checked -- #4215 (SOLR-18123) uses CoreContainer.ALLOW_PATHS_SYSPROP (filesystem path restrictions), a different mechanism from this PR's systemSetPropertyEnableUrlAllowList/systemClearPropertySolrEnableUrlAllowList (URL-allowlist). No file or symbol overlap. If anything, this PR does what you asked for on #4215 for a different property -- removes the base-class toggle-helper wrappers and inlines the one System.setProperty(...) call at its only remaining caller, instead of keeping ceremony in SolrTestCaseJ4.

dsmiley · 2026-08-25T03:03:04Z

Thanks for looking into that.

lots of conflicts to resolve and a changelog to remove but otherwise I approve

@afterclass

…-allowlist-helpers Resolves conflicts from SOLR-18354's ErrorLogMuter migration (main), which touched the same 4 files: kept both sides' imports (AllowListUrlChecker from this branch, ErrorLogMuter from main), and in the two @afterclass teardown methods that had both a now-dead resetExceptionIgnores() call (superseded by main's scoped try-with-resources ErrorLogMuter usage) and a now-dead systemClearPropertySolrEnableUrlAllowList() call (removed by this branch), dropped both -- neither has any remaining purpose.

…est-framework-only change

serhiy-bzhezytskyy · 2026-08-25T10:36:18Z

Both done -- rebased on main and resolved a real conflict from SOLR-18354's ErrorLogMuter migration (dead resetExceptionIgnores()/systemClearPropertySolrEnableUrlAllowList() calls in two @AfterClass teardowns, both superseded), and removed the changelog entry.

epugh · 2026-08-25T11:10:31Z

running CI and then will merge... thnaks @dsmiley for reviewing.

epugh · 2026-08-27T01:25:22Z

test passed locally

…rs (#4790) (cherry picked from commit 1869a60)

serhiy-bzhezytskyy · 2026-08-21T17:05:11Z

What

Removes the deprecated SolrTestCaseJ4.systemSetPropertyEnableUrlAllowList(boolean) and systemClearPropertySolrEnableUrlAllowList() methods. Both were deprecated since 9.0 (SOLR-17864) as backwards-compatibility shims only, with no replacement API — systemClearPropertySolrEnableUrlAllowList() was already an empty no-op.

Scope

Bigger than a single method: 15 call sites across 13 files (solr-core tests + 2 solr-test-framework base classes: BaseDistributedSearchTestCase, SolrTestCaseHS).

Migrated every systemSetPropertyEnableUrlAllowList(value) call to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, String.valueOf(value)) directly — the exact body of the removed setter.
Deleted every systemClearPropertySolrEnableUrlAllowList() call outright (it did nothing).
In BaseDistributedSearchTestCase, that left clearSolrEnableUrlUrlAllowList() as an empty @AfterClass method with no other callers, so the whole method (and its now-unused @AfterClass import) was removed rather than left as a hollow shell.
Dropped 8 @SuppressWarnings("deprecation") annotations across 4 test files that existed solely to cover these calls.

Verification

Full-repo ./gradlew compileTestJava (exit 0) — confirms zero remaining references anywhere in the tree.
Targeted test runs green across every touched test class (TestTolerantSearch, TestHealthCheckHandlerLegacyMode, DistributedDebugComponentTest, TestSmileRequest, TestJsonRequest, TestJsonFacetRefinement, TestJsonFacetErrors, TestJsonRangeFacets, TestJsonFacets, TestReplicationHandler, TestUserManagedReplicationWithAuth).

Changelog

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so a type: removed changelog entry is included.

AI-assisted (Claude Sonnet 5)

serhiy-bzhezytskyy · 2026-08-21T17:05:18Z

cc @epugh (deprecated it, SOLR-17864)

epugh

LGTM.. one spurious thought, is there any chance that some of these tests do NOT need this setting at all? Sometimes settings like this get copy/n/pasted over multiple tests.

serhiy-bzhezytskyy · 2026-08-22T06:47:21Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

epugh · 2026-08-22T10:29:38Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

Awesome. did dc21831e629 get pushed? I didn't see it in this PR...

serhiy-bzhezytskyy · 2026-08-22T10:39:32Z

Sorry, pushed.

@afterclass

…/systemClearPropertySolrEnableUrlAllowList Both methods were deprecated since 9.0 (SOLR-17864, Eric Pugh, 2025-09-28) as backwards-compatibility shims only, with no replacement API -- systemClearPropertySolrEnableUrlAllowList() was already an empty no-op. Migrated all 15 call sites across 13 files to call System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, ...) directly (the exact body of the removed setter). Calls to the no-op clear method were deleted outright rather than replaced with anything. In BaseDistributedSearchTestCase, this left clearSolrEnableUrlUrlAllowList() as an empty @afterclass method with no other callers, so the whole method (and its now-unused @afterclass import) was deleted rather than left as a hollow shell. Also dropped 8 @SuppressWarnings("deprecation") annotations across 4 files that existed solely to cover these calls. Verified with a full-repo ./gradlew compileTestJava (exit 0) plus targeted test runs across every touched test class.

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so this removal is a real API break for downstream test code -- warrants a changelog entry per the same standard applied to SOLR-18354/SOLR-18356 earlier in this batch.

…etErrors Eric asked whether some of the migrated URL-allowlist settings were copy-pasted without actually being needed. Checked all 13 files by verifying each one's actual code path into AllowListUrlChecker (explicit shards= param, SolrInstances distributed queries, or IndexFetcher replication) -- confirmed empirically by temporarily removing the setting and re-running the test to see it fail with a 403, one representative case per category (TestTolerantSearch, TestSmileRequest, TestHealthCheckHandlerLegacyMode). TestJsonFacetErrors was the one exception: its SolrInstances scaffolding (initServers(), the servers field, the null-guarded stop() in tearDown) has been dead code since the file's creation in SOLR-14348 (2020-03-23, split out of TestJsonFacets) -- initServers() is declared but never called by any of the 5 test methods, all of which are single-node error-validation checks. Removed the scaffolding along with the now-pointless allow-list setting; the class's actual purpose (facet API error handling) is untouched and needs no distributed servers.

…temSetPropertyEnableUrlAllowList Rebasing onto latest main pulled in solr/webapp (added by SOLR-8474 after this branch's original base), which still had one call to the now-removed systemSetPropertyEnableUrlAllowList(false). Migrated to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, "false") directly, the same pattern used at every other call site in this PR.

dsmiley · 2026-08-22T22:38:55Z

There's another PR that has stalled on the subject of ALLOW_PATHS in tests. I'm not sure if we should merge this right now, as it may delay that one? (not sure but just want to raise the risk/concern)

…eplicas() call solr:webapp wasn't covered by this PR's own migration sweep -- same recurring gap as SOLR-18390/apache#4778 and SOLR-18357/apache#4790. replicaCount() still called the now-removed getReplicas().size(); migrated to replicaStream().count() (cast to int, matching the method's return type), the same pattern used at every other call site in this PR.

…-allowlist-helpers

serhiy-bzhezytskyy · 2026-08-24T07:08:43Z

Checked -- #4215 (SOLR-18123) uses CoreContainer.ALLOW_PATHS_SYSPROP (filesystem path restrictions), a different mechanism from this PR's systemSetPropertyEnableUrlAllowList/systemClearPropertySolrEnableUrlAllowList (URL-allowlist). No file or symbol overlap. If anything, this PR does what you asked for on #4215 for a different property -- removes the base-class toggle-helper wrappers and inlines the one System.setProperty(...) call at its only remaining caller, instead of keeping ceremony in SolrTestCaseJ4.

dsmiley · 2026-08-25T03:03:04Z

Thanks for looking into that.

lots of conflicts to resolve and a changelog to remove but otherwise I approve

@afterclass

…-allowlist-helpers Resolves conflicts from SOLR-18354's ErrorLogMuter migration (main), which touched the same 4 files: kept both sides' imports (AllowListUrlChecker from this branch, ErrorLogMuter from main), and in the two @afterclass teardown methods that had both a now-dead resetExceptionIgnores() call (superseded by main's scoped try-with-resources ErrorLogMuter usage) and a now-dead systemClearPropertySolrEnableUrlAllowList() call (removed by this branch), dropped both -- neither has any remaining purpose.

…est-framework-only change

serhiy-bzhezytskyy · 2026-08-25T10:36:18Z

Both done -- rebased on main and resolved a real conflict from SOLR-18354's ErrorLogMuter migration (dead resetExceptionIgnores()/systemClearPropertySolrEnableUrlAllowList() calls in two @AfterClass teardowns, both superseded), and removed the changelog entry.

epugh · 2026-08-25T11:10:31Z

running CI and then will merge... thnaks @dsmiley for reviewing.

epugh · 2026-08-27T01:25:22Z

test passed locally

…rs (#4790) (cherry picked from commit 1869a60)

serhiy-bzhezytskyy · 2026-08-21T17:05:11Z

What

Removes the deprecated SolrTestCaseJ4.systemSetPropertyEnableUrlAllowList(boolean) and systemClearPropertySolrEnableUrlAllowList() methods. Both were deprecated since 9.0 (SOLR-17864) as backwards-compatibility shims only, with no replacement API — systemClearPropertySolrEnableUrlAllowList() was already an empty no-op.

Scope

Bigger than a single method: 15 call sites across 13 files (solr-core tests + 2 solr-test-framework base classes: BaseDistributedSearchTestCase, SolrTestCaseHS).

Migrated every systemSetPropertyEnableUrlAllowList(value) call to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, String.valueOf(value)) directly — the exact body of the removed setter.
Deleted every systemClearPropertySolrEnableUrlAllowList() call outright (it did nothing).
In BaseDistributedSearchTestCase, that left clearSolrEnableUrlUrlAllowList() as an empty @AfterClass method with no other callers, so the whole method (and its now-unused @AfterClass import) was removed rather than left as a hollow shell.
Dropped 8 @SuppressWarnings("deprecation") annotations across 4 test files that existed solely to cover these calls.

Verification

Full-repo ./gradlew compileTestJava (exit 0) — confirms zero remaining references anywhere in the tree.
Targeted test runs green across every touched test class (TestTolerantSearch, TestHealthCheckHandlerLegacyMode, DistributedDebugComponentTest, TestSmileRequest, TestJsonRequest, TestJsonFacetRefinement, TestJsonFacetErrors, TestJsonRangeFacets, TestJsonFacets, TestReplicationHandler, TestUserManagedReplicationWithAuth).

Changelog

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so a type: removed changelog entry is included.

AI-assisted (Claude Sonnet 5)

serhiy-bzhezytskyy · 2026-08-21T17:05:18Z

cc @epugh (deprecated it, SOLR-17864)

epugh

LGTM.. one spurious thought, is there any chance that some of these tests do NOT need this setting at all? Sometimes settings like this get copy/n/pasted over multiple tests.

serhiy-bzhezytskyy · 2026-08-22T06:47:21Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

epugh · 2026-08-22T10:29:38Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

Awesome. did dc21831e629 get pushed? I didn't see it in this PR...

serhiy-bzhezytskyy · 2026-08-22T10:39:32Z

Sorry, pushed.

@afterclass

…/systemClearPropertySolrEnableUrlAllowList Both methods were deprecated since 9.0 (SOLR-17864, Eric Pugh, 2025-09-28) as backwards-compatibility shims only, with no replacement API -- systemClearPropertySolrEnableUrlAllowList() was already an empty no-op. Migrated all 15 call sites across 13 files to call System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, ...) directly (the exact body of the removed setter). Calls to the no-op clear method were deleted outright rather than replaced with anything. In BaseDistributedSearchTestCase, this left clearSolrEnableUrlUrlAllowList() as an empty @afterclass method with no other callers, so the whole method (and its now-unused @afterclass import) was deleted rather than left as a hollow shell. Also dropped 8 @SuppressWarnings("deprecation") annotations across 4 files that existed solely to cover these calls. Verified with a full-repo ./gradlew compileTestJava (exit 0) plus targeted test runs across every touched test class.

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so this removal is a real API break for downstream test code -- warrants a changelog entry per the same standard applied to SOLR-18354/SOLR-18356 earlier in this batch.

…etErrors Eric asked whether some of the migrated URL-allowlist settings were copy-pasted without actually being needed. Checked all 13 files by verifying each one's actual code path into AllowListUrlChecker (explicit shards= param, SolrInstances distributed queries, or IndexFetcher replication) -- confirmed empirically by temporarily removing the setting and re-running the test to see it fail with a 403, one representative case per category (TestTolerantSearch, TestSmileRequest, TestHealthCheckHandlerLegacyMode). TestJsonFacetErrors was the one exception: its SolrInstances scaffolding (initServers(), the servers field, the null-guarded stop() in tearDown) has been dead code since the file's creation in SOLR-14348 (2020-03-23, split out of TestJsonFacets) -- initServers() is declared but never called by any of the 5 test methods, all of which are single-node error-validation checks. Removed the scaffolding along with the now-pointless allow-list setting; the class's actual purpose (facet API error handling) is untouched and needs no distributed servers.

…temSetPropertyEnableUrlAllowList Rebasing onto latest main pulled in solr/webapp (added by SOLR-8474 after this branch's original base), which still had one call to the now-removed systemSetPropertyEnableUrlAllowList(false). Migrated to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, "false") directly, the same pattern used at every other call site in this PR.

dsmiley · 2026-08-22T22:38:55Z

There's another PR that has stalled on the subject of ALLOW_PATHS in tests. I'm not sure if we should merge this right now, as it may delay that one? (not sure but just want to raise the risk/concern)

…eplicas() call solr:webapp wasn't covered by this PR's own migration sweep -- same recurring gap as SOLR-18390/apache#4778 and SOLR-18357/apache#4790. replicaCount() still called the now-removed getReplicas().size(); migrated to replicaStream().count() (cast to int, matching the method's return type), the same pattern used at every other call site in this PR.

…-allowlist-helpers

serhiy-bzhezytskyy · 2026-08-24T07:08:43Z

Checked -- #4215 (SOLR-18123) uses CoreContainer.ALLOW_PATHS_SYSPROP (filesystem path restrictions), a different mechanism from this PR's systemSetPropertyEnableUrlAllowList/systemClearPropertySolrEnableUrlAllowList (URL-allowlist). No file or symbol overlap. If anything, this PR does what you asked for on #4215 for a different property -- removes the base-class toggle-helper wrappers and inlines the one System.setProperty(...) call at its only remaining caller, instead of keeping ceremony in SolrTestCaseJ4.

dsmiley · 2026-08-25T03:03:04Z

Thanks for looking into that.

lots of conflicts to resolve and a changelog to remove but otherwise I approve

@afterclass

…-allowlist-helpers Resolves conflicts from SOLR-18354's ErrorLogMuter migration (main), which touched the same 4 files: kept both sides' imports (AllowListUrlChecker from this branch, ErrorLogMuter from main), and in the two @afterclass teardown methods that had both a now-dead resetExceptionIgnores() call (superseded by main's scoped try-with-resources ErrorLogMuter usage) and a now-dead systemClearPropertySolrEnableUrlAllowList() call (removed by this branch), dropped both -- neither has any remaining purpose.

…est-framework-only change

serhiy-bzhezytskyy · 2026-08-25T10:36:18Z

Both done -- rebased on main and resolved a real conflict from SOLR-18354's ErrorLogMuter migration (dead resetExceptionIgnores()/systemClearPropertySolrEnableUrlAllowList() calls in two @AfterClass teardowns, both superseded), and removed the changelog entry.

epugh · 2026-08-25T11:10:31Z

running CI and then will merge... thnaks @dsmiley for reviewing.

epugh · 2026-08-27T01:25:22Z

test passed locally

…rs (#4790) (cherry picked from commit 1869a60)

serhiy-bzhezytskyy · 2026-08-21T17:05:11Z

What

Removes the deprecated SolrTestCaseJ4.systemSetPropertyEnableUrlAllowList(boolean) and systemClearPropertySolrEnableUrlAllowList() methods. Both were deprecated since 9.0 (SOLR-17864) as backwards-compatibility shims only, with no replacement API — systemClearPropertySolrEnableUrlAllowList() was already an empty no-op.

Scope

Bigger than a single method: 15 call sites across 13 files (solr-core tests + 2 solr-test-framework base classes: BaseDistributedSearchTestCase, SolrTestCaseHS).

Migrated every systemSetPropertyEnableUrlAllowList(value) call to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, String.valueOf(value)) directly — the exact body of the removed setter.
Deleted every systemClearPropertySolrEnableUrlAllowList() call outright (it did nothing).
In BaseDistributedSearchTestCase, that left clearSolrEnableUrlUrlAllowList() as an empty @AfterClass method with no other callers, so the whole method (and its now-unused @AfterClass import) was removed rather than left as a hollow shell.
Dropped 8 @SuppressWarnings("deprecation") annotations across 4 test files that existed solely to cover these calls.

Verification

Full-repo ./gradlew compileTestJava (exit 0) — confirms zero remaining references anywhere in the tree.
Targeted test runs green across every touched test class (TestTolerantSearch, TestHealthCheckHandlerLegacyMode, DistributedDebugComponentTest, TestSmileRequest, TestJsonRequest, TestJsonFacetRefinement, TestJsonFacetErrors, TestJsonRangeFacets, TestJsonFacets, TestReplicationHandler, TestUserManagedReplicationWithAuth).

Changelog

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so a type: removed changelog entry is included.

AI-assisted (Claude Sonnet 5)

serhiy-bzhezytskyy · 2026-08-21T17:05:18Z

cc @epugh (deprecated it, SOLR-17864)

epugh

LGTM.. one spurious thought, is there any chance that some of these tests do NOT need this setting at all? Sometimes settings like this get copy/n/pasted over multiple tests.

serhiy-bzhezytskyy · 2026-08-22T06:47:21Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

epugh · 2026-08-22T10:29:38Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

Awesome. did dc21831e629 get pushed? I didn't see it in this PR...

serhiy-bzhezytskyy · 2026-08-22T10:39:32Z

Sorry, pushed.

@afterclass

…/systemClearPropertySolrEnableUrlAllowList Both methods were deprecated since 9.0 (SOLR-17864, Eric Pugh, 2025-09-28) as backwards-compatibility shims only, with no replacement API -- systemClearPropertySolrEnableUrlAllowList() was already an empty no-op. Migrated all 15 call sites across 13 files to call System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, ...) directly (the exact body of the removed setter). Calls to the no-op clear method were deleted outright rather than replaced with anything. In BaseDistributedSearchTestCase, this left clearSolrEnableUrlUrlAllowList() as an empty @afterclass method with no other callers, so the whole method (and its now-unused @afterclass import) was deleted rather than left as a hollow shell. Also dropped 8 @SuppressWarnings("deprecation") annotations across 4 files that existed solely to cover these calls. Verified with a full-repo ./gradlew compileTestJava (exit 0) plus targeted test runs across every touched test class.

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so this removal is a real API break for downstream test code -- warrants a changelog entry per the same standard applied to SOLR-18354/SOLR-18356 earlier in this batch.

…etErrors Eric asked whether some of the migrated URL-allowlist settings were copy-pasted without actually being needed. Checked all 13 files by verifying each one's actual code path into AllowListUrlChecker (explicit shards= param, SolrInstances distributed queries, or IndexFetcher replication) -- confirmed empirically by temporarily removing the setting and re-running the test to see it fail with a 403, one representative case per category (TestTolerantSearch, TestSmileRequest, TestHealthCheckHandlerLegacyMode). TestJsonFacetErrors was the one exception: its SolrInstances scaffolding (initServers(), the servers field, the null-guarded stop() in tearDown) has been dead code since the file's creation in SOLR-14348 (2020-03-23, split out of TestJsonFacets) -- initServers() is declared but never called by any of the 5 test methods, all of which are single-node error-validation checks. Removed the scaffolding along with the now-pointless allow-list setting; the class's actual purpose (facet API error handling) is untouched and needs no distributed servers.

…temSetPropertyEnableUrlAllowList Rebasing onto latest main pulled in solr/webapp (added by SOLR-8474 after this branch's original base), which still had one call to the now-removed systemSetPropertyEnableUrlAllowList(false). Migrated to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, "false") directly, the same pattern used at every other call site in this PR.

dsmiley · 2026-08-22T22:38:55Z

There's another PR that has stalled on the subject of ALLOW_PATHS in tests. I'm not sure if we should merge this right now, as it may delay that one? (not sure but just want to raise the risk/concern)

…eplicas() call solr:webapp wasn't covered by this PR's own migration sweep -- same recurring gap as SOLR-18390/apache#4778 and SOLR-18357/apache#4790. replicaCount() still called the now-removed getReplicas().size(); migrated to replicaStream().count() (cast to int, matching the method's return type), the same pattern used at every other call site in this PR.

…-allowlist-helpers

serhiy-bzhezytskyy · 2026-08-24T07:08:43Z

Checked -- #4215 (SOLR-18123) uses CoreContainer.ALLOW_PATHS_SYSPROP (filesystem path restrictions), a different mechanism from this PR's systemSetPropertyEnableUrlAllowList/systemClearPropertySolrEnableUrlAllowList (URL-allowlist). No file or symbol overlap. If anything, this PR does what you asked for on #4215 for a different property -- removes the base-class toggle-helper wrappers and inlines the one System.setProperty(...) call at its only remaining caller, instead of keeping ceremony in SolrTestCaseJ4.

dsmiley · 2026-08-25T03:03:04Z

Thanks for looking into that.

lots of conflicts to resolve and a changelog to remove but otherwise I approve

@afterclass

…-allowlist-helpers Resolves conflicts from SOLR-18354's ErrorLogMuter migration (main), which touched the same 4 files: kept both sides' imports (AllowListUrlChecker from this branch, ErrorLogMuter from main), and in the two @afterclass teardown methods that had both a now-dead resetExceptionIgnores() call (superseded by main's scoped try-with-resources ErrorLogMuter usage) and a now-dead systemClearPropertySolrEnableUrlAllowList() call (removed by this branch), dropped both -- neither has any remaining purpose.

…est-framework-only change

serhiy-bzhezytskyy · 2026-08-25T10:36:18Z

Both done -- rebased on main and resolved a real conflict from SOLR-18354's ErrorLogMuter migration (dead resetExceptionIgnores()/systemClearPropertySolrEnableUrlAllowList() calls in two @AfterClass teardowns, both superseded), and removed the changelog entry.

epugh · 2026-08-25T11:10:31Z

running CI and then will merge... thnaks @dsmiley for reviewing.

epugh · 2026-08-27T01:25:22Z

test passed locally

…rs (#4790) (cherry picked from commit 1869a60)

serhiy-bzhezytskyy · 2026-08-21T17:05:11Z

What

Removes the deprecated SolrTestCaseJ4.systemSetPropertyEnableUrlAllowList(boolean) and systemClearPropertySolrEnableUrlAllowList() methods. Both were deprecated since 9.0 (SOLR-17864) as backwards-compatibility shims only, with no replacement API — systemClearPropertySolrEnableUrlAllowList() was already an empty no-op.

Scope

Bigger than a single method: 15 call sites across 13 files (solr-core tests + 2 solr-test-framework base classes: BaseDistributedSearchTestCase, SolrTestCaseHS).

Migrated every systemSetPropertyEnableUrlAllowList(value) call to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, String.valueOf(value)) directly — the exact body of the removed setter.
Deleted every systemClearPropertySolrEnableUrlAllowList() call outright (it did nothing).
In BaseDistributedSearchTestCase, that left clearSolrEnableUrlUrlAllowList() as an empty @AfterClass method with no other callers, so the whole method (and its now-unused @AfterClass import) was removed rather than left as a hollow shell.
Dropped 8 @SuppressWarnings("deprecation") annotations across 4 test files that existed solely to cover these calls.

Verification

Full-repo ./gradlew compileTestJava (exit 0) — confirms zero remaining references anywhere in the tree.
Targeted test runs green across every touched test class (TestTolerantSearch, TestHealthCheckHandlerLegacyMode, DistributedDebugComponentTest, TestSmileRequest, TestJsonRequest, TestJsonFacetRefinement, TestJsonFacetErrors, TestJsonRangeFacets, TestJsonFacets, TestReplicationHandler, TestUserManagedReplicationWithAuth).

Changelog

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so a type: removed changelog entry is included.

AI-assisted (Claude Sonnet 5)

serhiy-bzhezytskyy · 2026-08-21T17:05:18Z

cc @epugh (deprecated it, SOLR-17864)

epugh

LGTM.. one spurious thought, is there any chance that some of these tests do NOT need this setting at all? Sometimes settings like this get copy/n/pasted over multiple tests.

serhiy-bzhezytskyy · 2026-08-22T06:47:21Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

epugh · 2026-08-22T10:29:38Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

Awesome. did dc21831e629 get pushed? I didn't see it in this PR...

serhiy-bzhezytskyy · 2026-08-22T10:39:32Z

Sorry, pushed.

@afterclass

…/systemClearPropertySolrEnableUrlAllowList Both methods were deprecated since 9.0 (SOLR-17864, Eric Pugh, 2025-09-28) as backwards-compatibility shims only, with no replacement API -- systemClearPropertySolrEnableUrlAllowList() was already an empty no-op. Migrated all 15 call sites across 13 files to call System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, ...) directly (the exact body of the removed setter). Calls to the no-op clear method were deleted outright rather than replaced with anything. In BaseDistributedSearchTestCase, this left clearSolrEnableUrlUrlAllowList() as an empty @afterclass method with no other callers, so the whole method (and its now-unused @afterclass import) was deleted rather than left as a hollow shell. Also dropped 8 @SuppressWarnings("deprecation") annotations across 4 files that existed solely to cover these calls. Verified with a full-repo ./gradlew compileTestJava (exit 0) plus targeted test runs across every touched test class.

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so this removal is a real API break for downstream test code -- warrants a changelog entry per the same standard applied to SOLR-18354/SOLR-18356 earlier in this batch.

…etErrors Eric asked whether some of the migrated URL-allowlist settings were copy-pasted without actually being needed. Checked all 13 files by verifying each one's actual code path into AllowListUrlChecker (explicit shards= param, SolrInstances distributed queries, or IndexFetcher replication) -- confirmed empirically by temporarily removing the setting and re-running the test to see it fail with a 403, one representative case per category (TestTolerantSearch, TestSmileRequest, TestHealthCheckHandlerLegacyMode). TestJsonFacetErrors was the one exception: its SolrInstances scaffolding (initServers(), the servers field, the null-guarded stop() in tearDown) has been dead code since the file's creation in SOLR-14348 (2020-03-23, split out of TestJsonFacets) -- initServers() is declared but never called by any of the 5 test methods, all of which are single-node error-validation checks. Removed the scaffolding along with the now-pointless allow-list setting; the class's actual purpose (facet API error handling) is untouched and needs no distributed servers.

…temSetPropertyEnableUrlAllowList Rebasing onto latest main pulled in solr/webapp (added by SOLR-8474 after this branch's original base), which still had one call to the now-removed systemSetPropertyEnableUrlAllowList(false). Migrated to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, "false") directly, the same pattern used at every other call site in this PR.

dsmiley · 2026-08-22T22:38:55Z

There's another PR that has stalled on the subject of ALLOW_PATHS in tests. I'm not sure if we should merge this right now, as it may delay that one? (not sure but just want to raise the risk/concern)

…eplicas() call solr:webapp wasn't covered by this PR's own migration sweep -- same recurring gap as SOLR-18390/apache#4778 and SOLR-18357/apache#4790. replicaCount() still called the now-removed getReplicas().size(); migrated to replicaStream().count() (cast to int, matching the method's return type), the same pattern used at every other call site in this PR.

…-allowlist-helpers

serhiy-bzhezytskyy · 2026-08-24T07:08:43Z

Checked -- #4215 (SOLR-18123) uses CoreContainer.ALLOW_PATHS_SYSPROP (filesystem path restrictions), a different mechanism from this PR's systemSetPropertyEnableUrlAllowList/systemClearPropertySolrEnableUrlAllowList (URL-allowlist). No file or symbol overlap. If anything, this PR does what you asked for on #4215 for a different property -- removes the base-class toggle-helper wrappers and inlines the one System.setProperty(...) call at its only remaining caller, instead of keeping ceremony in SolrTestCaseJ4.

dsmiley · 2026-08-25T03:03:04Z

Thanks for looking into that.

lots of conflicts to resolve and a changelog to remove but otherwise I approve

@afterclass

…-allowlist-helpers Resolves conflicts from SOLR-18354's ErrorLogMuter migration (main), which touched the same 4 files: kept both sides' imports (AllowListUrlChecker from this branch, ErrorLogMuter from main), and in the two @afterclass teardown methods that had both a now-dead resetExceptionIgnores() call (superseded by main's scoped try-with-resources ErrorLogMuter usage) and a now-dead systemClearPropertySolrEnableUrlAllowList() call (removed by this branch), dropped both -- neither has any remaining purpose.

…est-framework-only change

serhiy-bzhezytskyy · 2026-08-25T10:36:18Z

Both done -- rebased on main and resolved a real conflict from SOLR-18354's ErrorLogMuter migration (dead resetExceptionIgnores()/systemClearPropertySolrEnableUrlAllowList() calls in two @AfterClass teardowns, both superseded), and removed the changelog entry.

epugh · 2026-08-25T11:10:31Z

running CI and then will merge... thnaks @dsmiley for reviewing.

epugh · 2026-08-27T01:25:22Z

test passed locally

…rs (#4790) (cherry picked from commit 1869a60)

serhiy-bzhezytskyy · 2026-08-21T17:05:11Z

What

Removes the deprecated SolrTestCaseJ4.systemSetPropertyEnableUrlAllowList(boolean) and systemClearPropertySolrEnableUrlAllowList() methods. Both were deprecated since 9.0 (SOLR-17864) as backwards-compatibility shims only, with no replacement API — systemClearPropertySolrEnableUrlAllowList() was already an empty no-op.

Scope

Bigger than a single method: 15 call sites across 13 files (solr-core tests + 2 solr-test-framework base classes: BaseDistributedSearchTestCase, SolrTestCaseHS).

Migrated every systemSetPropertyEnableUrlAllowList(value) call to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, String.valueOf(value)) directly — the exact body of the removed setter.
Deleted every systemClearPropertySolrEnableUrlAllowList() call outright (it did nothing).
In BaseDistributedSearchTestCase, that left clearSolrEnableUrlUrlAllowList() as an empty @AfterClass method with no other callers, so the whole method (and its now-unused @AfterClass import) was removed rather than left as a hollow shell.
Dropped 8 @SuppressWarnings("deprecation") annotations across 4 test files that existed solely to cover these calls.

Verification

Full-repo ./gradlew compileTestJava (exit 0) — confirms zero remaining references anywhere in the tree.
Targeted test runs green across every touched test class (TestTolerantSearch, TestHealthCheckHandlerLegacyMode, DistributedDebugComponentTest, TestSmileRequest, TestJsonRequest, TestJsonFacetRefinement, TestJsonFacetErrors, TestJsonRangeFacets, TestJsonFacets, TestReplicationHandler, TestUserManagedReplicationWithAuth).

Changelog

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so a type: removed changelog entry is included.

AI-assisted (Claude Sonnet 5)

serhiy-bzhezytskyy · 2026-08-21T17:05:18Z

cc @epugh (deprecated it, SOLR-17864)

epugh

LGTM.. one spurious thought, is there any chance that some of these tests do NOT need this setting at all? Sometimes settings like this get copy/n/pasted over multiple tests.

serhiy-bzhezytskyy · 2026-08-22T06:47:21Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

epugh · 2026-08-22T10:29:38Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

Awesome. did dc21831e629 get pushed? I didn't see it in this PR...

serhiy-bzhezytskyy · 2026-08-22T10:39:32Z

Sorry, pushed.

@afterclass

…/systemClearPropertySolrEnableUrlAllowList Both methods were deprecated since 9.0 (SOLR-17864, Eric Pugh, 2025-09-28) as backwards-compatibility shims only, with no replacement API -- systemClearPropertySolrEnableUrlAllowList() was already an empty no-op. Migrated all 15 call sites across 13 files to call System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, ...) directly (the exact body of the removed setter). Calls to the no-op clear method were deleted outright rather than replaced with anything. In BaseDistributedSearchTestCase, this left clearSolrEnableUrlUrlAllowList() as an empty @afterclass method with no other callers, so the whole method (and its now-unused @afterclass import) was deleted rather than left as a hollow shell. Also dropped 8 @SuppressWarnings("deprecation") annotations across 4 files that existed solely to cover these calls. Verified with a full-repo ./gradlew compileTestJava (exit 0) plus targeted test runs across every touched test class.

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so this removal is a real API break for downstream test code -- warrants a changelog entry per the same standard applied to SOLR-18354/SOLR-18356 earlier in this batch.

…etErrors Eric asked whether some of the migrated URL-allowlist settings were copy-pasted without actually being needed. Checked all 13 files by verifying each one's actual code path into AllowListUrlChecker (explicit shards= param, SolrInstances distributed queries, or IndexFetcher replication) -- confirmed empirically by temporarily removing the setting and re-running the test to see it fail with a 403, one representative case per category (TestTolerantSearch, TestSmileRequest, TestHealthCheckHandlerLegacyMode). TestJsonFacetErrors was the one exception: its SolrInstances scaffolding (initServers(), the servers field, the null-guarded stop() in tearDown) has been dead code since the file's creation in SOLR-14348 (2020-03-23, split out of TestJsonFacets) -- initServers() is declared but never called by any of the 5 test methods, all of which are single-node error-validation checks. Removed the scaffolding along with the now-pointless allow-list setting; the class's actual purpose (facet API error handling) is untouched and needs no distributed servers.

…temSetPropertyEnableUrlAllowList Rebasing onto latest main pulled in solr/webapp (added by SOLR-8474 after this branch's original base), which still had one call to the now-removed systemSetPropertyEnableUrlAllowList(false). Migrated to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, "false") directly, the same pattern used at every other call site in this PR.

dsmiley · 2026-08-22T22:38:55Z

There's another PR that has stalled on the subject of ALLOW_PATHS in tests. I'm not sure if we should merge this right now, as it may delay that one? (not sure but just want to raise the risk/concern)

…eplicas() call solr:webapp wasn't covered by this PR's own migration sweep -- same recurring gap as SOLR-18390/apache#4778 and SOLR-18357/apache#4790. replicaCount() still called the now-removed getReplicas().size(); migrated to replicaStream().count() (cast to int, matching the method's return type), the same pattern used at every other call site in this PR.

…-allowlist-helpers

serhiy-bzhezytskyy · 2026-08-24T07:08:43Z

Checked -- #4215 (SOLR-18123) uses CoreContainer.ALLOW_PATHS_SYSPROP (filesystem path restrictions), a different mechanism from this PR's systemSetPropertyEnableUrlAllowList/systemClearPropertySolrEnableUrlAllowList (URL-allowlist). No file or symbol overlap. If anything, this PR does what you asked for on #4215 for a different property -- removes the base-class toggle-helper wrappers and inlines the one System.setProperty(...) call at its only remaining caller, instead of keeping ceremony in SolrTestCaseJ4.

dsmiley · 2026-08-25T03:03:04Z

Thanks for looking into that.

lots of conflicts to resolve and a changelog to remove but otherwise I approve

@afterclass

…-allowlist-helpers Resolves conflicts from SOLR-18354's ErrorLogMuter migration (main), which touched the same 4 files: kept both sides' imports (AllowListUrlChecker from this branch, ErrorLogMuter from main), and in the two @afterclass teardown methods that had both a now-dead resetExceptionIgnores() call (superseded by main's scoped try-with-resources ErrorLogMuter usage) and a now-dead systemClearPropertySolrEnableUrlAllowList() call (removed by this branch), dropped both -- neither has any remaining purpose.

…est-framework-only change

serhiy-bzhezytskyy · 2026-08-25T10:36:18Z

Both done -- rebased on main and resolved a real conflict from SOLR-18354's ErrorLogMuter migration (dead resetExceptionIgnores()/systemClearPropertySolrEnableUrlAllowList() calls in two @AfterClass teardowns, both superseded), and removed the changelog entry.

epugh · 2026-08-25T11:10:31Z

running CI and then will merge... thnaks @dsmiley for reviewing.

epugh · 2026-08-27T01:25:22Z

test passed locally

…rs (#4790) (cherry picked from commit 1869a60)

serhiy-bzhezytskyy · 2026-08-21T17:05:11Z

What

Removes the deprecated SolrTestCaseJ4.systemSetPropertyEnableUrlAllowList(boolean) and systemClearPropertySolrEnableUrlAllowList() methods. Both were deprecated since 9.0 (SOLR-17864) as backwards-compatibility shims only, with no replacement API — systemClearPropertySolrEnableUrlAllowList() was already an empty no-op.

Scope

Bigger than a single method: 15 call sites across 13 files (solr-core tests + 2 solr-test-framework base classes: BaseDistributedSearchTestCase, SolrTestCaseHS).

Migrated every systemSetPropertyEnableUrlAllowList(value) call to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, String.valueOf(value)) directly — the exact body of the removed setter.
Deleted every systemClearPropertySolrEnableUrlAllowList() call outright (it did nothing).
In BaseDistributedSearchTestCase, that left clearSolrEnableUrlUrlAllowList() as an empty @AfterClass method with no other callers, so the whole method (and its now-unused @AfterClass import) was removed rather than left as a hollow shell.
Dropped 8 @SuppressWarnings("deprecation") annotations across 4 test files that existed solely to cover these calls.

Verification

Full-repo ./gradlew compileTestJava (exit 0) — confirms zero remaining references anywhere in the tree.
Targeted test runs green across every touched test class (TestTolerantSearch, TestHealthCheckHandlerLegacyMode, DistributedDebugComponentTest, TestSmileRequest, TestJsonRequest, TestJsonFacetRefinement, TestJsonFacetErrors, TestJsonRangeFacets, TestJsonFacets, TestReplicationHandler, TestUserManagedReplicationWithAuth).

Changelog

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so a type: removed changelog entry is included.

AI-assisted (Claude Sonnet 5)

serhiy-bzhezytskyy · 2026-08-21T17:05:18Z

cc @epugh (deprecated it, SOLR-17864)

epugh

LGTM.. one spurious thought, is there any chance that some of these tests do NOT need this setting at all? Sometimes settings like this get copy/n/pasted over multiple tests.

serhiy-bzhezytskyy · 2026-08-22T06:47:21Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

epugh · 2026-08-22T10:29:38Z

One did: TestJsonFacetErrors had SolrInstances scaffolding dead since it was split out of TestJsonFacets in SOLR-14348 (2020) -- initServers() never called, all 5 tests are single-node. Removed it (dc21831e629). The other 12 checked out -- each fails with a 403 without the setting.

Awesome. did dc21831e629 get pushed? I didn't see it in this PR...

serhiy-bzhezytskyy · 2026-08-22T10:39:32Z

Sorry, pushed.

@afterclass

…/systemClearPropertySolrEnableUrlAllowList Both methods were deprecated since 9.0 (SOLR-17864, Eric Pugh, 2025-09-28) as backwards-compatibility shims only, with no replacement API -- systemClearPropertySolrEnableUrlAllowList() was already an empty no-op. Migrated all 15 call sites across 13 files to call System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, ...) directly (the exact body of the removed setter). Calls to the no-op clear method were deleted outright rather than replaced with anything. In BaseDistributedSearchTestCase, this left clearSolrEnableUrlUrlAllowList() as an empty @afterclass method with no other callers, so the whole method (and its now-unused @afterclass import) was deleted rather than left as a hollow shell. Also dropped 8 @SuppressWarnings("deprecation") annotations across 4 files that existed solely to cover these calls. Verified with a full-repo ./gradlew compileTestJava (exit 0) plus targeted test runs across every touched test class.

solr-test-framework is a published Maven artifact and these were protected static methods reachable by subclasses, so this removal is a real API break for downstream test code -- warrants a changelog entry per the same standard applied to SOLR-18354/SOLR-18356 earlier in this batch.

…etErrors Eric asked whether some of the migrated URL-allowlist settings were copy-pasted without actually being needed. Checked all 13 files by verifying each one's actual code path into AllowListUrlChecker (explicit shards= param, SolrInstances distributed queries, or IndexFetcher replication) -- confirmed empirically by temporarily removing the setting and re-running the test to see it fail with a 403, one representative case per category (TestTolerantSearch, TestSmileRequest, TestHealthCheckHandlerLegacyMode). TestJsonFacetErrors was the one exception: its SolrInstances scaffolding (initServers(), the servers field, the null-guarded stop() in tearDown) has been dead code since the file's creation in SOLR-14348 (2020-03-23, split out of TestJsonFacets) -- initServers() is declared but never called by any of the 5 test methods, all of which are single-node error-validation checks. Removed the scaffolding along with the now-pointless allow-list setting; the class's actual purpose (facet API error handling) is untouched and needs no distributed servers.

…temSetPropertyEnableUrlAllowList Rebasing onto latest main pulled in solr/webapp (added by SOLR-8474 after this branch's original base), which still had one call to the now-removed systemSetPropertyEnableUrlAllowList(false). Migrated to System.setProperty(AllowListUrlChecker.ENABLE_URL_ALLOW_LIST, "false") directly, the same pattern used at every other call site in this PR.

dsmiley · 2026-08-22T22:38:55Z

There's another PR that has stalled on the subject of ALLOW_PATHS in tests. I'm not sure if we should merge this right now, as it may delay that one? (not sure but just want to raise the risk/concern)

…eplicas() call solr:webapp wasn't covered by this PR's own migration sweep -- same recurring gap as SOLR-18390/apache#4778 and SOLR-18357/apache#4790. replicaCount() still called the now-removed getReplicas().size(); migrated to replicaStream().count() (cast to int, matching the method's return type), the same pattern used at every other call site in this PR.

…-allowlist-helpers

serhiy-bzhezytskyy · 2026-08-24T07:08:43Z

Checked -- #4215 (SOLR-18123) uses CoreContainer.ALLOW_PATHS_SYSPROP (filesystem path restrictions), a different mechanism from this PR's systemSetPropertyEnableUrlAllowList/systemClearPropertySolrEnableUrlAllowList (URL-allowlist). No file or symbol overlap. If anything, this PR does what you asked for on #4215 for a different property -- removes the base-class toggle-helper wrappers and inlines the one System.setProperty(...) call at its only remaining caller, instead of keeping ceremony in SolrTestCaseJ4.

dsmiley · 2026-08-25T03:03:04Z

Thanks for looking into that.

lots of conflicts to resolve and a changelog to remove but otherwise I approve

@afterclass

…-allowlist-helpers Resolves conflicts from SOLR-18354's ErrorLogMuter migration (main), which touched the same 4 files: kept both sides' imports (AllowListUrlChecker from this branch, ErrorLogMuter from main), and in the two @afterclass teardown methods that had both a now-dead resetExceptionIgnores() call (superseded by main's scoped try-with-resources ErrorLogMuter usage) and a now-dead systemClearPropertySolrEnableUrlAllowList() call (removed by this branch), dropped both -- neither has any remaining purpose.

…est-framework-only change

serhiy-bzhezytskyy · 2026-08-25T10:36:18Z

Both done -- rebased on main and resolved a real conflict from SOLR-18354's ErrorLogMuter migration (dead resetExceptionIgnores()/systemClearPropertySolrEnableUrlAllowList() calls in two @AfterClass teardowns, both superseded), and removed the changelog entry.

epugh · 2026-08-25T11:10:31Z

running CI and then will merge... thnaks @dsmiley for reviewing.

epugh · 2026-08-27T01:25:22Z

test passed locally

…rs (#4790) (cherry picked from commit 1869a60)

github-actionsBot added test-framework tests cat:search labels Aug 21, 2026

epugh approved these changes Aug 21, 2026
View reviewed changes

epugh self-assigned this Aug 21, 2026

epugh added the no-changelog label Aug 22, 2026

serhiy-bzhezytskyy added 4 commits August 22, 2026 14:33

serhiy-bzhezytskyy force-pushed the SOLR-18357-remove-url-allowlist-helpers branch from dc21831 to b4062afCompare August 22, 2026 11:36

github-actionsBot added the admin-ui label Aug 22, 2026

Merge remote-tracking branch 'origin/main' into SOLR-18357-remove-url…
b0e2790
…-allowlist-helpers

dsmiley added this to the 10.x milestone Aug 25, 2026

serhiy-bzhezytskyy added 2 commits August 25, 2026 10:46

SOLR-18357: remove changelog entry per dsmiley's review -- internal t…
32a62f5
…est-framework-only change

epugh merged commit 1869a60 into apache:mainAug 27, 2026
5 of 7 checks passed

dsmiley pushed a commit that referenced this pull request Aug 29, 2026
SOLR-18357: Remove SolrTestCaseJ4 URL-allowlist system-property helpe…
9276a90
…rs (#4790) (cherry picked from commit 1869a60)

github-actionsBot added test-framework tests cat:search labels Aug 21, 2026

epugh approved these changes Aug 21, 2026
View reviewed changes

epugh self-assigned this Aug 21, 2026

epugh added the no-changelog label Aug 22, 2026

serhiy-bzhezytskyy added 4 commits August 22, 2026 14:33

serhiy-bzhezytskyy force-pushed the SOLR-18357-remove-url-allowlist-helpers branch from dc21831 to b4062afCompare August 22, 2026 11:36

github-actionsBot added the admin-ui label Aug 22, 2026

Merge remote-tracking branch 'origin/main' into SOLR-18357-remove-url…
b0e2790
…-allowlist-helpers

dsmiley added this to the 10.x milestone Aug 25, 2026

serhiy-bzhezytskyy added 2 commits August 25, 2026 10:46

SOLR-18357: remove changelog entry per dsmiley's review -- internal t…
32a62f5
…est-framework-only change

epugh merged commit 1869a60 into apache:mainAug 27, 2026
5 of 7 checks passed

dsmiley pushed a commit that referenced this pull request Aug 29, 2026
SOLR-18357: Remove SolrTestCaseJ4 URL-allowlist system-property helpe…
9276a90
…rs (#4790) (cherry picked from commit 1869a60)

github-actionsBot added test-framework tests cat:search labels Aug 21, 2026

epugh approved these changes Aug 21, 2026
View reviewed changes

epugh self-assigned this Aug 21, 2026

epugh added the no-changelog label Aug 22, 2026

serhiy-bzhezytskyy added 4 commits August 22, 2026 14:33

serhiy-bzhezytskyy force-pushed the SOLR-18357-remove-url-allowlist-helpers branch from dc21831 to b4062afCompare August 22, 2026 11:36

github-actionsBot added the admin-ui label Aug 22, 2026

Merge remote-tracking branch 'origin/main' into SOLR-18357-remove-url…
b0e2790
…-allowlist-helpers

dsmiley added this to the 10.x milestone Aug 25, 2026

serhiy-bzhezytskyy added 2 commits August 25, 2026 10:46

SOLR-18357: remove changelog entry per dsmiley's review -- internal t…
32a62f5
…est-framework-only change

epugh merged commit 1869a60 into apache:mainAug 27, 2026
5 of 7 checks passed

dsmiley pushed a commit that referenced this pull request Aug 29, 2026
SOLR-18357: Remove SolrTestCaseJ4 URL-allowlist system-property helpe…
9276a90
…rs (#4790) (cherry picked from commit 1869a60)

github-actionsBot added test-framework tests cat:search labels Aug 21, 2026

epugh approved these changes Aug 21, 2026
View reviewed changes

epugh self-assigned this Aug 21, 2026

epugh added the no-changelog label Aug 22, 2026

serhiy-bzhezytskyy added 4 commits August 22, 2026 14:33

serhiy-bzhezytskyy force-pushed the SOLR-18357-remove-url-allowlist-helpers branch from dc21831 to b4062afCompare August 22, 2026 11:36

github-actionsBot added the admin-ui label Aug 22, 2026

Merge remote-tracking branch 'origin/main' into SOLR-18357-remove-url…
b0e2790
…-allowlist-helpers

dsmiley added this to the 10.x milestone Aug 25, 2026

serhiy-bzhezytskyy added 2 commits August 25, 2026 10:46

SOLR-18357: remove changelog entry per dsmiley's review -- internal t…
32a62f5
…est-framework-only change

epugh merged commit 1869a60 into apache:mainAug 27, 2026
5 of 7 checks passed

dsmiley pushed a commit that referenced this pull request Aug 29, 2026
SOLR-18357: Remove SolrTestCaseJ4 URL-allowlist system-property helpe…
9276a90
…rs (#4790) (cherry picked from commit 1869a60)

github-actionsBot added test-framework tests cat:search labels Aug 21, 2026

epugh approved these changes Aug 21, 2026
View reviewed changes

epugh self-assigned this Aug 21, 2026

epugh added the no-changelog label Aug 22, 2026

serhiy-bzhezytskyy added 4 commits August 22, 2026 14:33

serhiy-bzhezytskyy force-pushed the SOLR-18357-remove-url-allowlist-helpers branch from dc21831 to b4062afCompare August 22, 2026 11:36

github-actionsBot added the admin-ui label Aug 22, 2026

Merge remote-tracking branch 'origin/main' into SOLR-18357-remove-url…
b0e2790
…-allowlist-helpers

dsmiley added this to the 10.x milestone Aug 25, 2026

serhiy-bzhezytskyy added 2 commits August 25, 2026 10:46

SOLR-18357: remove changelog entry per dsmiley's review -- internal t…
32a62f5
…est-framework-only change

epugh merged commit 1869a60 into apache:mainAug 27, 2026
5 of 7 checks passed

dsmiley pushed a commit that referenced this pull request Aug 29, 2026
SOLR-18357: Remove SolrTestCaseJ4 URL-allowlist system-property helpe…
9276a90
…rs (#4790) (cherry picked from commit 1869a60)

github-actionsBot added test-framework tests cat:search labels Aug 21, 2026

epugh approved these changes Aug 21, 2026
View reviewed changes

epugh self-assigned this Aug 21, 2026

epugh added the no-changelog label Aug 22, 2026

serhiy-bzhezytskyy added 4 commits August 22, 2026 14:33

serhiy-bzhezytskyy force-pushed the SOLR-18357-remove-url-allowlist-helpers branch from dc21831 to b4062afCompare August 22, 2026 11:36

github-actionsBot added the admin-ui label Aug 22, 2026

Merge remote-tracking branch 'origin/main' into SOLR-18357-remove-url…
b0e2790
…-allowlist-helpers

dsmiley added this to the 10.x milestone Aug 25, 2026

serhiy-bzhezytskyy added 2 commits August 25, 2026 10:46

SOLR-18357: remove changelog entry per dsmiley's review -- internal t…
32a62f5
…est-framework-only change

epugh merged commit 1869a60 into apache:mainAug 27, 2026
5 of 7 checks passed

dsmiley pushed a commit that referenced this pull request Aug 29, 2026
SOLR-18357: Remove SolrTestCaseJ4 URL-allowlist system-property helpe…
9276a90
…rs (#4790) (cherry picked from commit 1869a60)

github-actionsBot added test-framework tests cat:search labels Aug 21, 2026

epugh approved these changes Aug 21, 2026
View reviewed changes

epugh self-assigned this Aug 21, 2026

epugh added the no-changelog label Aug 22, 2026

serhiy-bzhezytskyy added 4 commits August 22, 2026 14:33

serhiy-bzhezytskyy force-pushed the SOLR-18357-remove-url-allowlist-helpers branch from dc21831 to b4062afCompare August 22, 2026 11:36

github-actionsBot added the admin-ui label Aug 22, 2026

Merge remote-tracking branch 'origin/main' into SOLR-18357-remove-url…
b0e2790
…-allowlist-helpers

dsmiley added this to the 10.x milestone Aug 25, 2026

serhiy-bzhezytskyy added 2 commits August 25, 2026 10:46

SOLR-18357: remove changelog entry per dsmiley's review -- internal t…
32a62f5
…est-framework-only change

epugh merged commit 1869a60 into apache:mainAug 27, 2026
5 of 7 checks passed

dsmiley pushed a commit that referenced this pull request Aug 29, 2026
SOLR-18357: Remove SolrTestCaseJ4 URL-allowlist system-property helpe…
9276a90
…rs (#4790) (cherry picked from commit 1869a60)

github-actionsBot added test-framework tests cat:search labels Aug 21, 2026

epugh approved these changes Aug 21, 2026
View reviewed changes

epugh self-assigned this Aug 21, 2026

epugh added the no-changelog label Aug 22, 2026

serhiy-bzhezytskyy added 4 commits August 22, 2026 14:33

serhiy-bzhezytskyy force-pushed the SOLR-18357-remove-url-allowlist-helpers branch from dc21831 to b4062afCompare August 22, 2026 11:36

github-actionsBot added the admin-ui label Aug 22, 2026

Merge remote-tracking branch 'origin/main' into SOLR-18357-remove-url…
b0e2790
…-allowlist-helpers

dsmiley added this to the 10.x milestone Aug 25, 2026

serhiy-bzhezytskyy added 2 commits August 25, 2026 10:46

SOLR-18357: remove changelog entry per dsmiley's review -- internal t…
32a62f5
…est-framework-only change

epugh merged commit 1869a60 into apache:mainAug 27, 2026
5 of 7 checks passed

dsmiley pushed a commit that referenced this pull request Aug 29, 2026
SOLR-18357: Remove SolrTestCaseJ4 URL-allowlist system-property helpe…
9276a90
…rs (#4790) (cherry picked from commit 1869a60)

Uh oh!

Conversation

serhiy-bzhezytskyy commented Aug 21, 2026

What

Scope

Verification

Changelog

Uh oh!

serhiy-bzhezytskyy commented Aug 21, 2026

Uh oh!

epugh left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-bzhezytskyy commented Aug 22, 2026

Uh oh!

epugh commented Aug 22, 2026

Uh oh!

serhiy-bzhezytskyy commented Aug 22, 2026

Uh oh!

dsmiley commented Aug 22, 2026

Uh oh!

serhiy-bzhezytskyy commented Aug 24, 2026

Uh oh!

dsmiley commented Aug 25, 2026

Uh oh!

serhiy-bzhezytskyy commented Aug 25, 2026

Uh oh!

epugh commented Aug 25, 2026

Uh oh!

epugh commented Aug 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

serhiy-bzhezytskyy commented Aug 21, 2026

What

Scope

Verification

Changelog

Uh oh!

serhiy-bzhezytskyy commented Aug 21, 2026

Uh oh!

epugh left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-bzhezytskyy commented Aug 22, 2026

Uh oh!

epugh commented Aug 22, 2026

Uh oh!

serhiy-bzhezytskyy commented Aug 22, 2026

Uh oh!

dsmiley commented Aug 22, 2026

Uh oh!

serhiy-bzhezytskyy commented Aug 24, 2026

Uh oh!

dsmiley commented Aug 25, 2026

Uh oh!

serhiy-bzhezytskyy commented Aug 25, 2026

Uh oh!

epugh commented Aug 25, 2026

Uh oh!

epugh commented Aug 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants