Uh oh!
There was an error while loading. Please reload this page.
[SPARK-11551][DOC][Example]Replace example code in ml-features.md using include_example - #10002
[SPARK-11551][DOC][Example]Replace example code in ml-features.md using include_example#10002somideshmukh wants to merge 13 commits into
Conversation
AmplabJenkins
commented
Nov 26, 2015
Can one of the admins verify this patch? |
yinxusen
commented
Nov 27, 2015
Hi @somideshmukh, since it's lots of files in this pull request, I send a pull request to your repo and you can see it here: somideshmukh#1 All of my modifications are there, you can check the code and merge it if it looks good to you. Then we can check the correctness of those newly added files. |
yinxusen
commented
Nov 27, 2015
You can see the files changed in that pull request. I make changes in your original code. The main issues there are:
I also add Python files that you missed and 3 Java codes plus with 1 Scala code. |
yinxusen
commented
Nov 27, 2015
Besides, there is no need to create a new pull request every time you changing your code. You can modify your previous code and push the changes in current branch. |
yinxusen
commented
Nov 28, 2015
@somideshmukh This is really a bunch of code. I check some errors as described above for my carelessness and sorry for that. And after fixing those errors, I can get it run in my computer. I'll also check the example codes one by one to make sure every code example is runnable without errors. |
yinxusen
commented
Nov 28, 2015
I think the conflict is due to some changes in |
There was a problem hiding this comment.
add a white space here " categorical features:", otherwise the output is like this Chose 351categorical features: ...
somideshmukh
commented
Dec 1, 2015
I have made the changes you have mentioned in the given Java and Scala files and push the changes in Branch "SomilBranch1.33". I haven't modified Python files since I haven't work on that files and I donot have python knowledge. |
somideshmukh
commented
Dec 1, 2015
Pls check it and let me know whether you have got the changes. |
srowen
commented
Dec 1, 2015
@somideshmukh the changes are here as you can see, but your branch still needs a rebase. |
yinxusen
commented
Dec 1, 2015
@somideshmukh I'll help you change the python issues, then I will send another PR to you soon. |
yinxusen
commented
Dec 1, 2015
@somideshmukh I have already fix all issues and merged with master. You can accept my pull request here somideshmukh#2. Even though it looks very large, it can be small when you merging it. I believe we can merge the PR after that. |
merge with master
yinxusen
commented
Dec 2, 2015
@mengxr LGTM |
yinxusen
commented
Dec 8, 2015
@mengxr Shall we merge this PR? I find there are also some PRs modify ml-features.md, so I think it's better to merge it before new conflicts emerging. |
There was a problem hiding this comment.
minor: remove extra } at the end. You can submit a follow-up PR to fix it.
yinxusen
commented
Dec 8, 2015
@mengxr Yes, I'll submit a follow-up pr to refine it. |
mengxr
commented
Dec 8, 2015
Merged into master and branch-1.6. Thanks! |
…ing include_example Made new patch contaning only markdown examples moved to exmaple/folder. Ony three java code were not shfted since they were contaning compliation error ,these classes are 1)StandardScale 2)NormalizerExample 3)VectorIndexer Author: Xusen Yin <yinxusen@gmail.com> Author: somideshmukh <somilde@us.ibm.com> Closes#10002 from somideshmukh/SomilBranch1.33. (cherry picked from commit 78209b0) Signed-off-by: Xiangrui Meng <meng@databricks.com>
JoshRosen
commented
Dec 8, 2015
Looks like this broke the Python style tests: I guess that Jenkins never tested this PR? |
liancheng
commented
Dec 8, 2015
Reverting this one to bring back Spark builds. |
yinxusen
commented
Dec 8, 2015
Sorry for that, I will help fixing them. |
yinxusen
commented
Dec 8, 2015
@somideshmukh I give you another PR to fix the Python style issue: somideshmukh#3. After merging it, we can call jenkins testing once here. |
This reverts PR apache#10002, commit 78209b0. The original PR wasn't tested on Jenkins before being merged. Author: Cheng Lian <lian@databricks.com> Closesapache#10200 from liancheng/revert-pr-10002.
liancheng
commented
Dec 8, 2015
Hit some network issue, just reverted this PR from master and branch-1.6 in #10200. |
yinxusen
commented
Dec 9, 2015
@somideshmukh Do you still have time work on this? Pleas let me know ASAP thanks. |
liancheng
commented
Dec 9, 2015
@yinxusen Maybe you can fork this PR branch and get it merged. You may add a note in your PR description to remind committers to attribute your PR to @somideshmukh. We can specify primary author while merging a PR using our merge script. |
yinxusen
commented
Dec 9, 2015
Sure, I will do it |
somideshmukh
commented
Dec 9, 2015
Please let me know what needs to be done,I have not worked on python code. |
yinxusen
commented
Dec 9, 2015
@somideshmukh Never mind, I add a new one on behalf of you: #10219@liancheng if it looks good to you, please help me merge it after the Jenkins test. Thanks! |
Made new patch contaning only markdown examples moved to exmaple/folder.
Ony three java code were not shfted since they were contaning compliation error ,these classes are
1)StandardScale 2)NormalizerExample 3)VectorIndexer