Uh oh!
There was an error while loading. Please reload this page.
[SPARK-12024][SQL] More efficient multi-column counting. - #10015
Closed
hvanhovell wants to merge 1 commit into
Closed
[SPARK-12024][SQL] More efficient multi-column counting.#10015hvanhovell wants to merge 1 commit into
hvanhovell wants to merge 1 commit into
Conversation
SparkQA
commented
Nov 27, 2015
Test build #46814 has finished for PR 10015 at commit
|
yhuai
commented
Nov 29, 2015
Contributor
LGTM. Merging to master and 1.6. |
asfgit pushed a commit
that referenced
this pull request
Nov 29, 2015
In #9409 we enabled multi-column counting. The approach taken in that PR introduces a bit of overhead by first creating a row only to check if all of the columns are non-null. This PR fixes that technical debt. Count now takes multiple columns as its input. In order to make this work I have also added support for multiple columns in the single distinct code path. cc yhuai Author: Herman van Hovell <hvanhovell@questtec.nl> Closes#10015 from hvanhovell/SPARK-12024. (cherry picked from commit 3d28081) Signed-off-by: Yin Huai <yhuai@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #9409 we enabled multi-column counting. The approach taken in that PR introduces a bit of overhead by first creating a row only to check if all of the columns are non-null.
This PR fixes that technical debt. Count now takes multiple columns as its input. In order to make this work I have also added support for multiple columns in the single distinct code path.
cc @yhuai