Uh oh!
There was an error while loading. Please reload this page.
[SPARK-12016][MLlib][PySpark] Wrap Word2VecModel when loading it in pyspark - #10100
[SPARK-12016][MLlib][PySpark] Wrap Word2VecModel when loading it in pyspark#10100viirya wants to merge 4 commits into
Conversation
SparkQA
commented
Dec 2, 2015
Test build #47056 has finished for PR 10100 at commit
|
SparkQA
commented
Dec 2, 2015
Test build #47061 has finished for PR 10100 at commit
|
holdenk
commented
Dec 3, 2015
This is only a suggestion, but looking at the other Java loadable models which are also wrapped in python it seems the standard approach is to instead add a load[X] method to the PythonMLLibAPI instead of doing the wrapper in Python. Might be worth doing that way just for consistencies sake - what are your thoughts? |
viirya
commented
Dec 3, 2015
It makes sense. Thanks. I will update this later. |
SparkQA
commented
Dec 3, 2015
Test build #47122 has finished for PR 10100 at commit
|
viirya
commented
Dec 5, 2015
viirya
commented
Dec 13, 2015
ping @davies Can you take a look of this? It should be straightforward one. |
davies
commented
Dec 14, 2015
LGTM, merging this into master, thanks! |
… pyspark JIRA: https://issues.apache.org/jira/browse/SPARK-12016 We should not directly use Word2VecModel in pyspark. We need to wrap it in a Word2VecModelWrapper when loading it in pyspark. Author: Liang-Chi Hsieh <viirya@appier.com> Closes#10100 from viirya/fix-load-py-wordvecmodel. (cherry picked from commit b51a4cd) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
… pyspark JIRA: https://issues.apache.org/jira/browse/SPARK-12016 We should not directly use Word2VecModel in pyspark. We need to wrap it in a Word2VecModelWrapper when loading it in pyspark. Author: Liang-Chi Hsieh <viirya@appier.com> Closes#10100 from viirya/fix-load-py-wordvecmodel. (cherry picked from commit b51a4cd) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
jkbradley
commented
Jan 7, 2016
I just backported this to 1.6 and 1.5 |
JIRA: https://issues.apache.org/jira/browse/SPARK-12016
We should not directly use Word2VecModel in pyspark. We need to wrap it in a Word2VecModelWrapper when loading it in pyspark.