Uh oh!
There was an error while loading. Please reload this page.
[SPARK-12537] [SQL] Add option to accept quoting of all character backslash quoting mechanism - #10497
[SPARK-12537] [SQL] Add option to accept quoting of all character backslash quoting mechanism#10497Cazen wants to merge 12 commits into
Conversation
Cazen
commented
Dec 28, 2015
recreate pull request(10496->10497) |
srowen
commented
Dec 28, 2015
In general you do not need to open a new pull request. But before you make a PR, best to finish the questions on the JIRA. I'm not yet clear why this is regularly needed, or when |
There was a problem hiding this comment.
i don't think you need the trailing \ yet
Cazen
commented
Dec 30, 2015
Changed default value to true and remove \ in comment |
SparkQA
commented
Dec 30, 2015
Test build #2264 has finished for PR 10497 at commit
|
There was a problem hiding this comment.
This default should be false, right?
There was a problem hiding this comment.
Happy New Year Owen!
At first, I've created PR with false default.
But Xin advised to me that "I'd actually change the default value to true" in previous comment so I've changed.
If you think it doesn't make sense, please call me again. I will change that immediately
Thank you
Cazen
commented
Jan 3, 2016
Could I ask to run test? |
SparkQA
commented
Jan 4, 2016
Test build #2308 has finished for PR 10497 at commit
|
rxin
commented
Jan 4, 2016
I've merged this. Thanks! |
rxin
commented
Jan 4, 2016
@Cazen you probably want to add this email to your github profile so the commit shows up under your account: Cazen@korea.com |
Cazen
commented
Jan 4, 2016
Thank you @rxin I've added my email address to github profile. |
We can provides the option to choose JSON parser can be enabled to accept quoting of all character or not.