[SPARK-12533][SQL] hiveContext.table() throws the wrong exception by thomastechs · Pull Request #10529 · apache/spark

thomastechs · 2015-12-30T21:33:49Z

Avoiding the the No such table exception and throwing analysis exception as per the bug: SPARK-12533

marmbrus · 2015-12-31T08:46:02Z

OK to test

rxin · 2015-12-31T09:35:11Z

this will fail style checker. you will need to add a space before and after +.

Sure @rxin .Will update the fix and create a new pull request

Incorporating the review comments

thomastechs · 2015-12-31T11:12:10Z

@rxin I have updated the style check difference ,you mentioned. and committed to my branch. And I see it is reflected here in this same pull request. Could you please review?

SparkQA · 2015-12-31T23:25:35Z

Test build #2281 has finished for PR 10529 at commit 4463a95.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

thomastechs · 2016-01-01T04:18:56Z

working on the updates

jayadevanmurali · 2016-01-01T16:20:31Z

I think, there would be a reference update in Analyzer.scala as we discussed @thomastechs

AnalysisException is updated as per the bug fic mentions SPARK-12533

thomastechs · 2016-01-01T16:25:17Z

@jayadevanmurali : Yes, modifying the files which has reference to the code fix, as well.

As the exception type returned from the lookupRelation method is changed to AnalysisException, it is updated here also.

Updating the test case methods corresponding the bug fix [SPARK-12438]

thomastechs · 2016-01-01T16:38:52Z

@rxin and @marmbrus and @SparkQA . The fix including the testcases have been committed. Could you please initiate a test build?

SparkQA · 2016-01-01T22:05:23Z

Test build #2288 has finished for PR 10529 at commit 76a9623.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Removed the AnalysisException class import command, as it throws (hidden) warning. The Analysis Exception is already available in this package

Reverting to change to previous state, because the relevant test cases are to be triggered.

thomastechs · 2016-01-02T17:05:48Z

@SparkQA , @rxin The changes are done to fix the unit test failure. Could you please initiate a test build?

SparkQA · 2016-01-03T09:12:54Z

Test build #2299 has finished for PR 10529 at commit f75c44e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

rxin · 2016-01-03T19:09:16Z

I've merged this. Thanks.

marmbrus · 2016-01-04T17:45:47Z

Does this mean that NoSuchTableException is not used anywhere? We should probably get rid of it then. Though, I think I'd have a slight preference for keeping a special exception internally. The point of this extra control flow is so that we can attach line position information to this specific exception in the analyzer.

@marmbrus Shouldn't we have fixed this issue by marking the relation unresolved and let the analyzer generate a proper AnalysisException ? If we were to use the catalog interface for some other purpose like tooling etc keeping the generic catalog exceptions would have been better ?

Update Catalog.scala
c833cae
Avoiding the the No such table exception and throwing analysis exception as per the bug: SPARK-12533

rxin reviewed Dec 31, 2015
View reviewed changes

Update Catalog.scala- [SPARK-12533]
4463a95
Incorporating the review comments

Updated Catalog.scala with standard message
9e8797e
AnalysisException is updated as per the bug fic mentions SPARK-12533

thomastechs added 2 commits January 1, 2016 21:59

Updated Analyzer.scala with the AnalysisException
6639956
As the exception type returned from the lookupRelation method is changed to AnalysisException, it is updated here also.

[SPARK-12438][SQL]Updating CachedTableSuite.scala
76a9623
Updating the test case methods corresponding the bug fix [SPARK-12438]

thomastechs changed the title ~~[SPARK-12438][SQL] hiveContext.table() throws the wrong exception~~[SPARK-12533][SQL] hiveContext.table() throws the wrong exceptionJan 1, 2016

thomastechs added 2 commits January 2, 2016 22:26

[SPARK-12533]Updated CachedTableSuite.scala
f74a9a2
Removed the AnalysisException class import command, as it throws (hidden) warning. The Analysis Exception is already available in this package

[SPARK-12533]Updated Analyzer.scala
f75c44e
Reverting to change to previous state, because the relevant test cases are to be triggered.

asfgit closed this in c82924dJan 3, 2016

marmbrus reviewed Jan 4, 2016
View reviewed changes

Uh oh!

Conversation

thomastechs commented Dec 30, 2015

Uh oh!

marmbrus commented Dec 31, 2015

Uh oh!

rxinDec 31, 2015

Choose a reason for hiding this comment

Uh oh!

thomastechsDec 31, 2015

Choose a reason for hiding this comment

Uh oh!

thomastechs commented Dec 31, 2015

Uh oh!

SparkQA commented Dec 31, 2015

Uh oh!

thomastechs commented Jan 1, 2016

Uh oh!

jayadevanmurali commented Jan 1, 2016

Uh oh!

thomastechs commented Jan 1, 2016

Uh oh!

thomastechs commented Jan 1, 2016

Uh oh!

SparkQA commented Jan 1, 2016

Uh oh!

thomastechs commented Jan 2, 2016

Uh oh!

SparkQA commented Jan 3, 2016

Uh oh!

rxin commented Jan 3, 2016

Uh oh!

marmbrusJan 4, 2016

Choose a reason for hiding this comment

Uh oh!

dilipbiswalJan 4, 2016

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants