Uh oh!
There was an error while loading. Please reload this page.
[SPARK-10359][PROJECT-INFRA] Use more random number in dev/test-dependencies.sh; fix version switching - #10558
[SPARK-10359][PROJECT-INFRA] Use more random number in dev/test-dependencies.sh; fix version switching#10558JoshRosen wants to merge 6 commits into
Conversation
JoshRosen
commented
Jan 2, 2016
/cc @rxin |
SparkQA
commented
Jan 2, 2016
Test build #48589 has finished for PR 10558 at commit
|
JoshRosen
commented
Jan 2, 2016
Test failure was due to Python 3. |
SparkQA
commented
Jan 2, 2016
Test build #48591 has finished for PR 10558 at commit
|
SparkQA
commented
Jan 3, 2016
Test build #48594 has finished for PR 10558 at commit
|
SparkQA
commented
Jan 3, 2016
Test build #2298 has finished for PR 10558 at commit
|
rxin
commented
Jan 3, 2016
lgtm On Saturday, January 2, 2016, Apache Spark QA notifications@github.com
|
JoshRosen
commented
Jan 3, 2016
Jenkins, retest this please. |
SparkQA
commented
Jan 3, 2016
Test build #48595 has finished for PR 10558 at commit
|
JoshRosen
commented
Jan 3, 2016
Aha! It looks like the code for resetting the version has a problem:
|
JoshRosen
commented
Jan 3, 2016
Pushed a fix for the version issue, so I'm going to run this a few more times then will merge if it's passing. |
SparkQA
commented
Jan 3, 2016
Test build #48596 has finished for PR 10558 at commit
|
SparkQA
commented
Jan 3, 2016
Test build #48599 has finished for PR 10558 at commit
|
JoshRosen
commented
Jan 3, 2016
Jenkins, retest this please. |
SparkQA
commented
Jan 3, 2016
Test build #48615 has finished for PR 10558 at commit
|
JoshRosen
commented
Jan 4, 2016
Jenkins, retest this please. |
SparkQA
commented
Jan 4, 2016
Test build #48640 has finished for PR 10558 at commit
|
JoshRosen
commented
Jan 4, 2016
Merging now. |
…dencies.sh; fix version switching This patch aims to fix another potential source of flakiness in the `dev/test-dependencies.sh` script. pwendell's original patch and my version used `$(date +%s | tail -c6)` to generate a suffix to use when installing temporary Spark versions into the local Maven cache, but this value only changes once per second and thus is highly collision-prone when concurrent builds launch on AMPLab Jenkins. In order to reduce the potential for conflicts, this patch updates the script to call Python's random number generator instead. I also fixed a bug in how we captured the original project version; the bug was causing the exit handler code to fail. Author: Josh Rosen <joshrosen@databricks.com> Closesapache#10558 from JoshRosen/build-dep-tests-round-3.
…dencies.sh; fix version switching This patch aims to fix another potential source of flakiness in the `dev/test-dependencies.sh` script. pwendell's original patch and my version used `$(date +%s | tail -c6)` to generate a suffix to use when installing temporary Spark versions into the local Maven cache, but this value only changes once per second and thus is highly collision-prone when concurrent builds launch on AMPLab Jenkins. In order to reduce the potential for conflicts, this patch updates the script to call Python's random number generator instead. I also fixed a bug in how we captured the original project version; the bug was causing the exit handler code to fail. Author: Josh Rosen <joshrosen@databricks.com> Closesapache#10558 from JoshRosen/build-dep-tests-round-3.
This patch aims to fix another potential source of flakiness in the
dev/test-dependencies.shscript.@pwendell's original patch and my version used
$(date +%s | tail -c6)to generate a suffix to use when installing temporary Spark versions into the local Maven cache, but this value only changes once per second and thus is highly collision-prone when concurrent builds launch on AMPLab Jenkins. In order to reduce the potential for conflicts, this patch updates the script to call Python's random number generator instead.I also fixed a bug in how we captured the original project version; the bug was causing the exit handler code to fail.