Skip to content

[SPARK-12747][SQL] Use correct type name for Postgres JDBC's real array - #10695

Closed
viirya wants to merge 5 commits into
apache:masterfrom
viirya:fix-postgres-jdbc
Closed

[SPARK-12747][SQL] Use correct type name for Postgres JDBC's real array#10695
viirya wants to merge 5 commits into
apache:masterfrom
viirya:fix-postgres-jdbc

Conversation

@viirya

Copy link
Copy Markdown
Member

https://issues.apache.org/jira/browse/SPARK-12747

Postgres JDBC driver uses "FLOAT4" or "FLOAT8" not "real".

@SparkQA

Copy link
Copy Markdown

Test build #49147 has finished for PR 10695 at commit 8f84ea4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #49154 has started for PR 10695 at commit 0389ea8.

@viirya

Copy link
Copy Markdown
MemberAuthor

Type mapping for various types *** FAILED *** (1 second, 877 milliseconds)
[info] Array(0.11, 0.22) did not equal Array(0.11, 0.22) (PostgresIntegrationSuite.scala:84)

Array(0.11, 0.22) did not equal Array(0.11, 0.22)?

@SparkQA

Copy link
Copy Markdown

Test build #49209 has finished for PR 10695 at commit c731a93.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #49220 has finished for PR 10695 at commit 3a9acaa.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #49233 has finished for PR 10695 at commit e9ec20f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@blbradley

Copy link
Copy Markdown
Contributor

Looks good, but you should squash your commits into one.

@JoshRosen

Copy link
Copy Markdown
Contributor

@blbradley, no need to squash the commits; that happens automatically as part of our PR merge script.

@viirya

Copy link
Copy Markdown
MemberAuthor

ping @rxin

@viirya

Copy link
Copy Markdown
MemberAuthor

ping @liancheng@yhuai@rxin Can you see if this fixing is good for you? Thanks.

@blbradley

Copy link
Copy Markdown
Contributor

This is blocking me. Can we get it merged soon?

I'm waiting to submit another PR to fix DecimalType also.

@viirya

Copy link
Copy Markdown
MemberAuthor

ping @liancheng@yhuai@rxin How do you think about this? Can we merge it now?

@rxin

rxin commented Jan 22, 2016

Copy link
Copy Markdown
Contributor

Thanks - I've merged this in master and branch-1.6.

asfgit pushed a commit that referenced this pull request Jan 22, 2016
https://issues.apache.org/jira/browse/SPARK-12747
Postgres JDBC driver uses "FLOAT4" or "FLOAT8" not "real".
Author: Liang-Chi Hsieh <viirya@gmail.com>
Closes#10695 from viirya/fix-postgres-jdbc.
(cherry picked from commit 55c7dd0)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@viirya
viirya deleted the fix-postgres-jdbc branch December 27, 2023 18:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@viirya@SparkQA@blbradley@JoshRosen@rxin