Skip to content

[SPARK-12711][ML] ML StopWordsRemover does not protect itself from column name duplication - #10741

Closed
grzegorz-chilkiewicz wants to merge 5 commits into
apache:masterfrom
grzegorz-chilkiewicz:master
Closed

[SPARK-12711][ML] ML StopWordsRemover does not protect itself from column name duplication#10741
grzegorz-chilkiewicz wants to merge 5 commits into
apache:masterfrom
grzegorz-chilkiewicz:master

Conversation

@grzegorz-chilkiewicz

@grzegorz-chilkiewiczgrzegorz-chilkiewicz commented Jan 13, 2016

Copy link
Copy Markdown
Contributor

Fixes problem and verifies fix by test suite.
Also - adds optional parameter: nullable (Boolean) to: SchemaUtils.appendColumn
and deduplicates SchemaUtils.appendColumn functions.

@jkbradley

jkbradley commented Jan 13, 2016

Copy link
Copy Markdown
Member

Could you please add tag "[ML]" to the PR title?

jkbradley
jkbradley reviewed Jan 13, 2016
View reviewed changes
Comment threadmllib/src/test/scala/org/apache/spark/ml/feature/StopWordsRemoverSuite.scala Outdated

@jkbradleyjkbradleyJan 13, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "outputCol"

@jkbradley

jkbradley commented Jan 13, 2016

Copy link
Copy Markdown
Member

Also, please add a (short) PR description (in your first PR comment) since that will become part of the commit message.

@SparkQA

SparkQA commented Jan 13, 2016

Copy link
Copy Markdown

Test build #2377 has finished for PR 10741 at commit ca9a852.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@grzegorz-chilkiewicz
[SPARK-12711][ML] ML StopWordsRemover does not protect itself from co…
37af391
…lumn name duplication
Fixes problem and verifies fix by test suite.
Also - adds optional parameter nullable (Boolean) to: SchemaUtils.appendColumn
and deduplicates SchemaUtils.appendColumn functions.
@grzegorz-chilkiewiczgrzegorz-chilkiewicz changed the title [SPARK-12711] ML StopWordsRemover does not protect itself from column name duplication[SPARK-12711][ML] ML StopWordsRemover does not protect itself from column name duplicationJan 14, 2016
@grzegorz-chilkiewicz

grzegorz-chilkiewicz commented Jan 26, 2016

Copy link
Copy Markdown
ContributorAuthor

Is everything ok with this PR?
Did I miss something?
Can we merge it with apache/spark ?

@jkbradley

jkbradley commented Jan 26, 2016

Copy link
Copy Markdown
Member

LGTM
I'll run tests before merging

@SparkQA

SparkQA commented Jan 26, 2016

Copy link
Copy Markdown

Test build #2461 has finished for PR 10741 at commit 37af391.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jkbradley
jkbradley reviewed Jan 26, 2016
View reviewed changes
Comment threadmllib/src/test/scala/org/apache/spark/ml/feature/StopWordsRemoverSuite.scala

@jkbradleyjkbradleyJan 26, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copy one of the datasets from an above test. That should fix the error.

@grzegorz-chilkiewiczgrzegorz-chilkiewiczJan 27, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed out that second column in dataSet was totally empty... - and that was the problem...
I do not want to make that example too complicated, because this test does not even check correctness of execution result
I'm sorry for problems

@marmbrus

marmbrus commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

ok to test

@jkbradley

jkbradley commented Feb 2, 2016

Copy link
Copy Markdown
Member

LGTM pending tests

@SparkQA

SparkQA commented Feb 2, 2016

Copy link
Copy Markdown

Test build #50573 has finished for PR 10741 at commit 49fd362.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley

jkbradley commented Feb 2, 2016

Copy link
Copy Markdown
Member

Merging with master and branch-1.6
Thanks for the PR!

asfgit pushed a commit that referenced this pull request Feb 2, 2016
@grzegorz-chilkiewicz@jkbradley
[SPARK-12711][ML] ML StopWordsRemover does not protect itself from co…
9c0cf22
…lumn name duplication
Fixes problem and verifies fix by test suite.
Also - adds optional parameter: nullable (Boolean) to: SchemaUtils.appendColumn
and deduplicates SchemaUtils.appendColumn functions.
Author: Grzegorz Chilkiewicz <grzegorz.chilkiewicz@codilime.com>
Closes#10741 from grzegorz-chilkiewicz/master.
(cherry picked from commit b1835d7)
Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
@asfgitasfgit closed this in b1835d7Feb 2, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grzegorz-chilkiewicz@jkbradley@SparkQA@marmbrus