Uh oh!
There was an error while loading. Please reload this page.
[SPARK-12841][SQL][branch-1.6] fix cast in filter - #10819
Conversation
cloud-fan
commented
Jan 18, 2016
cc @yhuai |
rxin
commented
Jan 18, 2016
Can you update the pull request description to include more information? The old pull request description is good. |
SparkQA
commented
Jan 18, 2016
Test build #49633 has finished for PR 10819 at commit
|
cloud-fan
commented
Jan 18, 2016
retest this please |
SparkQA
commented
Jan 19, 2016
Test build #49635 has finished for PR 10819 at commit
|
yhuai
commented
Jan 19, 2016
test this please |
SparkQA
commented
Jan 19, 2016
Test build #49638 has finished for PR 10819 at commit
|
cloud-fan
commented
Jan 19, 2016
something wrong with branch 1.6? cc @JoshRosen |
JoshRosen
commented
Jan 19, 2016
There might be something wrong with that build workspace's Ivy cache. If you have Jenkins access, you should be able to SSH in and wipe it away. |
cloud-fan
commented
Jan 19, 2016
retest this please |
SparkQA
commented
Jan 19, 2016
Test build #49655 has finished for PR 10819 at commit
|
yhuai
commented
Jan 19, 2016
Thanks! Merging to branch 1.6. |
In SPARK-10743 we wrap cast with `UnresolvedAlias` to give `Cast` a better alias if possible. However, for cases like filter, the `UnresolvedAlias` can't be resolved and actually we don't need a better alias for this case. This PR move the cast wrapping logic to `Column.named` so that we will only do it when we need a alias name. backport #10781 to 1.6 Author: Wenchen Fan <wenchen@databricks.com> Closes#10819 from cloud-fan/bug.
rxin
commented
Jan 19, 2016
@cloud-fan you'd need to close this pull request yourself since it was not merged into master. |
In SPARK-10743 we wrap cast with
UnresolvedAliasto giveCasta better alias if possible. However, for cases like filter, theUnresolvedAliascan't be resolved and actually we don't need a better alias for this case. This PR move the cast wrapping logic toColumn.namedso that we will only do it when we need a alias name.backport #10781 to 1.6