Skip to content

[SPARK-13067][SQL] workaround for a weird scala reflection problem - #10970

Closed
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:reflection
Closed

[SPARK-13067][SQL] workaround for a weird scala reflection problem#10970
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:reflection

Conversation

@cloud-fan

Copy link
Copy Markdown
Contributor

A simple workaround to avoid getting parameter types when convert a logical plan to json. Note that this bug only exists locally, but ok on jenkins, not sure why...

@cloud-fan

Copy link
Copy Markdown
ContributorAuthor

CC @davies@yhuai@marmbrus

@davies can you try it out locally?

@cloud-fan

Copy link
Copy Markdown
ContributorAuthor

retest this please

@SparkQA

Copy link
Copy Markdown

Test build #50316 has finished for PR 10970 at commit 7e66869.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan

Copy link
Copy Markdown
ContributorAuthor

retest this please

@SparkQA

Copy link
Copy Markdown

Test build #50320 has finished for PR 10970 at commit 7e66869.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #2472 has finished for PR 10970 at commit 7e66869.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin

rxin commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

"。" replace with "." ?

@davies

Copy link
Copy Markdown
Contributor

Tested it locally, test passed. LGTM, I'm merging this into master, thanks! (fixed the 。)

@rxin

rxin commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

@cloud-fan is this fixing a bug? If yes, please add a test somewhere.

@marmbrus

Copy link
Copy Markdown
Contributor

Existing tests were failing locally, but not on Jenkins. We are not sure why.

@rxin

rxin commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

OK got it. @cloud-fan Please add that to the pull request description next time.

@cloud-fan

Copy link
Copy Markdown
ContributorAuthor

Sorry I thought the JIRA description tells it, will add it to PR description next time.

@cloud-fan
cloud-fan deleted the reflection branch January 29, 2016 07:04
@rxin

rxin commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

Yea the pull request description gets merged as commit description, and is the only thing that sticks around forever.

@atronchi

Copy link
Copy Markdown

How can we workaround this problem when using 1.6.1?

@atronchi

Copy link
Copy Markdown

This solution does not seem to work for datasets on tables using complex types. e.g. Array[Int] still throws the exception java.lang.AssertionError: assertion failed: Unsound substitution from List(type T, type U) to List()

@cloud-fan

Copy link
Copy Markdown
ContributorAuthor

@atronchi can you create a JIRA and put the code that can reproduce the bug? thanks!

@atronchi

Copy link
Copy Markdown

The solution mentioned in [SPARK-17424] by @rdblue fixes this issue.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@cloud-fan@SparkQA@rxin@davies@marmbrus@atronchi