Uh oh!
There was an error while loading. Please reload this page.
[SPARK-13153][PySpark] ML persistence failed when handle no default value parameter - #11043
Closed
Wenpei wants to merge 3 commits into
Closed
[SPARK-13153][PySpark] ML persistence failed when handle no default value parameter#11043Wenpei wants to merge 3 commits into
Wenpei wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
We should check by isDefined rather than hasDefault here.
yanboliang
commented
Feb 3, 2016
Contributor
ping @mengxr@jkbradley |
Wenpei
commented
Feb 3, 2016
ContributorAuthor
It's OK now and ready to launch test. |
mengxr
commented
Feb 12, 2016
Contributor
ok to test |
mengxr
commented
Feb 12, 2016
Contributor
LGTM pending Jenins |
SparkQA
commented
Feb 12, 2016
Test build #51161 has finished for PR 11043 at commit
|
asfgit pushed a commit
that referenced
this pull request
Feb 12, 2016
…alue parameter Fix this defect by check default value exist or not. yanboliang Please help to review. Author: Tommy YU <tummyyu@163.com> Closes#11043 from Wenpei/spark-13153-handle-param-withnodefaultvalue. (cherry picked from commit d3e2e20) Signed-off-by: Xiangrui Meng <meng@databricks.com>
mengxr
commented
Feb 12, 2016
Contributor
Merged into master and branch-1.6. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this defect by check default value exist or not.
@yanboliang Please help to review.