Uh oh!
There was an error while loading. Please reload this page.
[SPARK-5095] remove flaky test - #11164
Conversation
rxin
commented
Feb 11, 2016
Can you explain a bit why it is flaky? If the test case is useful, we should just change "test" to "ignore" rather than removing it. |
SparkQA
commented
Feb 11, 2016
Test build #51076 has finished for PR 11164 at commit
|
There was a problem hiding this comment.
yeah, let's make this ignore("mesos kills ...") { ... } instead
andrewor14
commented
Feb 11, 2016
This test was added recently in #10993 so this is just reverting the test instead of reverting the whole patch. I do think we should use |
andrewor14
commented
Feb 11, 2016
Also @mgummelt can you either file a JIRA or add the same JIRA to the title of this patch? |
3af190b to
4e6b4dbComparemgummelt
commented
Feb 12, 2016
Updated the title. Kept the test, and overrode the start() method, which was previously starting a thread causing a race condition. I believe this should fix the problem. |
SparkQA
commented
Feb 12, 2016
Test build #51196 has finished for PR 11164 at commit
|
andrewor14
commented
Feb 12, 2016
Merged into master. Let's see whether this fixes it. |
Overrode the start() method, which was previously starting a thread causing a race condition. I believe this should fix the flaky test.