Uh oh!
There was an error while loading. Please reload this page.
[SPARK-13279] Remove unnecessary duplicate check in addPendingTask fu… - #11175
Closed
sitalkedia wants to merge 1 commit into
Closed
[SPARK-13279] Remove unnecessary duplicate check in addPendingTask fu…#11175sitalkedia wants to merge 1 commit into
sitalkedia wants to merge 1 commit into
Conversation
kayousterhout
commented
Feb 11, 2016
Contributor
Jenkins this is ok to test |
kayousterhout
commented
Feb 12, 2016
Contributor
Jenkins, test this please |
| list += index | ||
| } | ||
| list += index | ||
| } |
Contributor
There was a problem hiding this comment.
It strikes me that addTo is now only making a negative contribution toward understanding the code -- mostly because the "...if it's not already there" comment is now wrong. I don't see why the handful of uses of addTo shouldn't just be replaced with, e.g.:
pendingTasksForExecutor.getOrElseUpdate(e.executorId, newArrayBuffer) += indexsitalkediaforce-pushed
the
fix_stuck_driver
branch
from
February 12, 2016 00:46
3fe1af8 to
a0c3512Compare
sitalkediaforce-pushed
the
fix_stuck_driver
branch
from
February 12, 2016 00:50
a0c3512 to
26b4370Comparesrowen
commented
Feb 14, 2016
Member
Jenkins, test this please |
SparkQA
commented
Feb 14, 2016
Test build #51266 has finished for PR 11175 at commit
|
srowen
commented
Feb 15, 2016
Member
@kayousterhout I'll let you push the button on this one when you're sure but it looks OK to me. |
sitalkedia
commented
Feb 17, 2016
Author
@kayousterhout did you get some time to look into this? |
asfgit pushed a commit
that referenced
this pull request
Feb 17, 2016
This commit removes an unnecessary duplicate check in addPendingTask that meant that scheduling a task set took time proportional to (# tasks)^2. Author: Sital Kedia <skedia@fb.com> Closes#11175 from sitalkedia/fix_stuck_driver. (cherry picked from commit 1e1e31e) Signed-off-by: Kay Ousterhout <kayousterhout@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nction