Uh oh!
There was an error while loading. Please reload this page.
[SPARK-13354] [SQL] push filter throughout outer join - #11234
Closed
davies wants to merge 1 commit into
Closed
Conversation
gatorsmile
commented
Feb 17, 2016
Member
SparkQA
commented
Feb 17, 2016
Test build #51410 has finished for PR 11234 at commit
|
davies
commented
Feb 17, 2016
ContributorAuthor
@gatorsmile I will review those, you can take |
gatorsmile
commented
Feb 17, 2016
Member
Thank you very much! @davies Will do it. : ) |
| joinType match { | ||
| case Inner => | ||
| case _ if isInnerJoin(joinType, leftFilterConditions, rightFilterConditions) => |
Contributor
There was a problem hiding this comment.
I don't think we should be doing this kind of reasoning in this rule. If you are going to convert outer joins to inner joins that should be its own rule.
marmbrus
commented
Feb 18, 2016
Contributor
If we are going to reason about null intolerance we should do that in a principled way (and there is already a start in the form of constraints) and not just mix it randomly into existing rules. |
davies
commented
Feb 18, 2016
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a query
The condition
b.b > 10will filter out all the row that the b part of it is empty.In this case, we should use Inner join, and push down the filter into b.