Skip to content

[SPARK-12746][ML] ArrayType(_, true) should also accept ArrayType(_, false) fix for branch-1.6 - #11237

Closed
Earthson wants to merge 3 commits into
apache:branch-1.6from
Earthson:SPARK-13359
Closed

[SPARK-12746][ML] ArrayType(_, true) should also accept ArrayType(_, false) fix for branch-1.6#11237
Earthson wants to merge 3 commits into
apache:branch-1.6from
Earthson:SPARK-13359

Conversation

@Earthson

Copy link
Copy Markdown
Contributor

@EarthsonEarthson changed the title [ML] ArrayType(_, true) should also accept ArrayType(_, false) fix for branch-1.6[SPARK-13359][ML] ArrayType(_, true) should also accept ArrayType(_, false) fix for branch-1.6Feb 17, 2016
@Earthson

Copy link
Copy Markdown
ContributorAuthor

@mengxr Hi, Xiangrui, I've copied the code from master to fix SPARK-12746 for branch-1.6.

related: #10697

@JoshRosen

Copy link
Copy Markdown
Contributor

Jenkins, this is ok to test.

@SparkQA

Copy link
Copy Markdown

Test build #51458 has finished for PR 11237 at commit 2de848f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen

Copy link
Copy Markdown
Member

Please tag this for SPARK-12746 instead

@EarthsonEarthson changed the title [SPARK-13359][ML] ArrayType(_, true) should also accept ArrayType(_, false) fix for branch-1.6[SPARK-12746][ML] ArrayType(_, true) should also accept ArrayType(_, false) fix for branch-1.6Feb 19, 2016
@Earthson

Copy link
Copy Markdown
ContributorAuthor

def checkColumnTypes(
schema: StructType,
colName: String,
dataTypes: Seq[DataType],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent

@EarthsonEarthson changed the title [SPARK-12746][ML] ArrayType(_, true) should also accept ArrayType(_, false) fix for branch-1.6[SPARK-12746][SPARK-13359][ML] ArrayType(_, true) should also accept ArrayType(_, false) fix for branch-1.6Feb 19, 2016
@EarthsonEarthson changed the title [SPARK-12746][SPARK-13359][ML] ArrayType(_, true) should also accept ArrayType(_, false) fix for branch-1.6[SPARK-12746][ML] ArrayType(_, true) should also accept ArrayType(_, false) fix for branch-1.6Feb 19, 2016
@SparkQA

Copy link
Copy Markdown

Test build #51513 has finished for PR 11237 at commit 30655f5.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@Earthson

Copy link
Copy Markdown
ContributorAuthor

Jenkins, test this please.

@SparkQA

Copy link
Copy Markdown

Test build #51522 has finished for PR 11237 at commit 372588f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@Earthson

Copy link
Copy Markdown
ContributorAuthor

@srowen Is this ok to merge?

@srowen

Copy link
Copy Markdown
Member

OK by me though ideally @mengxr would merge. I'll do it tomorrow if not

asfgit pushed a commit that referenced this pull request Feb 23, 2016
…false) fix for branch-1.6
https://issues.apache.org/jira/browse/SPARK-13359
Author: Earthson Lu <Earthson.Lu@gmail.com>
Closes#11237 from Earthson/SPARK-13359.
@mengxr

Copy link
Copy Markdown
Contributor

Merged into branch-1.6. Thanks! @Earthson Could you please close this PR manually? PR sent to a specific branch won't be closed automatically.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Earthson@JoshRosen@SparkQA@srowen@mengxr@yanboliang