Uh oh!
There was an error while loading. Please reload this page.
[SPARK-13626] [core] Avoid duplicate config deprecation warnings. - #11510
Closed
vanzin wants to merge 4 commits into
Closed
[SPARK-13626] [core] Avoid duplicate config deprecation warnings.#11510vanzin wants to merge 4 commits into
vanzin wants to merge 4 commits into
Conversation
Three different things were needed to get rid of spurious warnings: - silence deprecation warnings when cloning configuration - change the way SparkHadoopUtil instantiates SparkConf to silence warnings - avoid creating new SparkConf instances where it's not needed. On top of that, I changed the way that Logging.scala detects the repl; now it uses a method that is overridden in the repl's Main class, and the hack in Utils.scala is not needed anymore. This makes the 2.11 repl behave like the 2.10 one and set the default log level to WARN, which is a lot better. Previously, this wasn't working because the 2.11 repl triggers log initialization earlier than the 2.10 one. I also removed and simplified some other code in the 2.11 repl's Main to avoid replicating logic that already exists elsewhere in Spark. Last but not least, fixed a compilation bug in a test for Scala 2.10. Tested the 2.11 repl in local and yarn modes.
SparkQA
commented
Mar 4, 2016
Test build #52442 has finished for PR 11510 at commit
|
SparkQA
commented
Mar 4, 2016
Test build #52474 has finished for PR 11510 at commit
|
SparkQA
commented
Mar 4, 2016
Test build #52476 has finished for PR 11510 at commit
|
SparkQA
commented
Mar 5, 2016
Test build #52496 has finished for PR 11510 at commit
|
vanzin
commented
Mar 8, 2016
ContributorAuthor
Ping anyone? |
vanzin
commented
Mar 11, 2016
ContributorAuthor
I assume no one has any problems with this, so I'll merge when tests pass again. retest this please |
SparkQA
commented
Mar 12, 2016
Test build #52951 has finished for PR 11510 at commit
|
vanzin
commented
Mar 14, 2016
ContributorAuthor
Merging to master. |
jeanlyn pushed a commit
to jeanlyn/spark
that referenced
this pull request
Mar 17, 2016
Three different things were needed to get rid of spurious warnings: - silence deprecation warnings when cloning configuration - change the way SparkHadoopUtil instantiates SparkConf to silence warnings - avoid creating new SparkConf instances where it's not needed. On top of that, I changed the way that Logging.scala detects the repl; now it uses a method that is overridden in the repl's Main class, and the hack in Utils.scala is not needed anymore. This makes the 2.11 repl behave like the 2.10 one and set the default log level to WARN, which is a lot better. Previously, this wasn't working because the 2.11 repl triggers log initialization earlier than the 2.10 one. I also removed and simplified some other code in the 2.11 repl's Main to avoid replicating logic that already exists elsewhere in Spark. Tested the 2.11 repl in local and yarn modes. Author: Marcelo Vanzin <vanzin@cloudera.com> Closesapache#11510 from vanzin/SPARK-13626.
roygao94 pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
Three different things were needed to get rid of spurious warnings: - silence deprecation warnings when cloning configuration - change the way SparkHadoopUtil instantiates SparkConf to silence warnings - avoid creating new SparkConf instances where it's not needed. On top of that, I changed the way that Logging.scala detects the repl; now it uses a method that is overridden in the repl's Main class, and the hack in Utils.scala is not needed anymore. This makes the 2.11 repl behave like the 2.10 one and set the default log level to WARN, which is a lot better. Previously, this wasn't working because the 2.11 repl triggers log initialization earlier than the 2.10 one. I also removed and simplified some other code in the 2.11 repl's Main to avoid replicating logic that already exists elsewhere in Spark. Tested the 2.11 repl in local and yarn modes. Author: Marcelo Vanzin <vanzin@cloudera.com> Closesapache#11510 from vanzin/SPARK-13626.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three different things were needed to get rid of spurious warnings:
warnings
On top of that, I changed the way that Logging.scala detects the repl;
now it uses a method that is overridden in the repl's Main class, and
the hack in Utils.scala is not needed anymore. This makes the 2.11 repl
behave like the 2.10 one and set the default log level to WARN, which
is a lot better. Previously, this wasn't working because the 2.11 repl
triggers log initialization earlier than the 2.10 one.
I also removed and simplified some other code in the 2.11 repl's Main
to avoid replicating logic that already exists elsewhere in Spark.
Tested the 2.11 repl in local and yarn modes.