Uh oh!
There was an error while loading. Please reload this page.
[SPARK-13663] Upgrade Snappy Java to 1.1.2.1 - #11524
Conversation
srowen
commented
Mar 4, 2016
Given it's a sub-maintenance release targeting this memory leak problem only, let's back-port for master/1.6. We already worked around it and can leave that change in place, but still helpful. |
srowen
commented
Mar 4, 2016
Jenkins test this please |
SparkQA
commented
Mar 4, 2016
Test build #52473 has finished for PR 11524 at commit
|
srowen
commented
Mar 4, 2016
Oops, you need to run the script to update the dependencies file to reflect this change. |
JoshRosen
commented
Mar 4, 2016
By the way, one important reason to leave the workaround in place is the fact that we've seen snappy-java get downgraded by user code when the user classpath takes precedence. For this reason, I imagine that in the long run we'll eventually want to shade this dep so that it can't be pulled lower. |
JoshRosen
commented
Mar 7, 2016
Ping. Can you run |
srowen
commented
Mar 10, 2016
yy2016
commented
Mar 10, 2016
Sorry, I wasn't checking github notifications. |
## What changes were proposed in this pull request? Update snappy to 1.1.2.1 to pull in a single fix -- the OOM fix we already worked around. Supersedes #11524 ## How was this patch tested? Jenkins tests. Author: Sean Owen <sowen@cloudera.com> Closes#11631 from srowen/SPARK-13663.
Update snappy to 1.1.2.1 to pull in a single fix -- the OOM fix we already worked around. Supersedes #11524 Jenkins tests. Author: Sean Owen <sowen@cloudera.com> Closes#11631 from srowen/SPARK-13663. (cherry picked from commit 927e22e) Signed-off-by: Sean Owen <sowen@cloudera.com>
## What changes were proposed in this pull request? Update snappy to 1.1.2.1 to pull in a single fix -- the OOM fix we already worked around. Supersedes apache#11524 ## How was this patch tested? Jenkins tests. Author: Sean Owen <sowen@cloudera.com> Closesapache#11631 from srowen/SPARK-13663.
What changes were proposed in this pull request?
The JVM memory leaky problem reported in xerial/snappy-java#131 has been resolved in 1.1.2.1 release.
This PR upgrades snappy-java to 1.1.2.1 release.
How was this patch tested?
Through unit tests.