Uh oh!
There was an error while loading. Please reload this page.
Cleanup on Connection, ConnectionManagerId, ConnectionManager classes part 2 - #1157
Closed
hsaputra wants to merge 2 commits into
Closed
Cleanup on Connection, ConnectionManagerId, ConnectionManager classes part 2#1157hsaputra wants to merge 2 commits into
hsaputra wants to merge 2 commits into
Conversation
…s working at the code there to help IDE: 1. Remove unused imports 2. Remove parentheses in method calls that do not have side affect. 3. Add parentheses in method calls that do have side effect. 4. Change if-else check (via isInstanceOf) for Connection class type with Scala expression for consitency and cleanliness. 5. Remove semicolon 6. Remove extra spaces.
AmplabJenkins
commented
Jun 20, 2014
Merged build triggered. |
AmplabJenkins
commented
Jun 20, 2014
Merged build started. |
AmplabJenkins
commented
Jun 20, 2014
Merged build finished. |
AmplabJenkins
commented
Jun 20, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15961/ |
rxin
commented
Jun 23, 2014
Contributor
Jenkins, retest this please. |
rxin
commented
Jun 23, 2014
Contributor
The changes LGTM. |
AmplabJenkins
commented
Jun 23, 2014
Merged build triggered. |
AmplabJenkins
commented
Jun 23, 2014
Merged build started. |
AmplabJenkins
commented
Jun 23, 2014
Merged build finished. |
AmplabJenkins
commented
Jun 23, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16020/ |
hsaputra
commented
Jun 23, 2014
ContributorAuthor
Just push changes to fix Scalastyle checks for over 100 char in a line. |
AmplabJenkins
commented
Jun 23, 2014
Merged build triggered. |
AmplabJenkins
commented
Jun 23, 2014
Merged build started. |
AmplabJenkins
commented
Jun 23, 2014
Merged build finished. |
AmplabJenkins
commented
Jun 23, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16038/ |
rxin
commented
Jun 23, 2014
Contributor
Jenkins, retest this please. |
AmplabJenkins
commented
Jun 23, 2014
Merged build triggered. |
AmplabJenkins
commented
Jun 23, 2014
Merged build started. |
AmplabJenkins
commented
Jun 23, 2014
Merged build finished. |
AmplabJenkins
commented
Jun 23, 2014
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16039/ |
hsaputra
commented
Jun 23, 2014
ContributorAuthor
Somehow the build is timed out, maybe running out resource to execute tests? =( |
rxin
commented
Jun 23, 2014
Contributor
Jenkins, retest this please. |
AmplabJenkins
commented
Jun 23, 2014
Merged build triggered. |
AmplabJenkins
commented
Jun 23, 2014
Merged build started. |
AmplabJenkins
commented
Jun 24, 2014
Merged build finished. All automated tests passed. |
AmplabJenkins
commented
Jun 24, 2014
All automated tests passed. |
rxin
commented
Jun 24, 2014
Contributor
Ok I'm merging this in master. Thanks! |
hsaputra
commented
Jun 24, 2014
ContributorAuthor
Thanks @rxin ! =) |
pdeyhim pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
… part 2 Cleanup on Connection, ConnectionManagerId, and ConnectionManager classes part 2 while I was working at the code there to help IDE: 1. Remove unused imports 2. Remove parentheses in method calls that do not have side affect. 3. Add parentheses in method calls that do have side effect or not simple get to object properties. 4. Change if-else check (via isInstanceOf) for Connection class type with Scala expression for consistency and cleanliness. 5. Remove semicolon 6. Remove extra spaces. 7. Remove redundant return for consistency Author: Henry Saputra <henry.saputra@gmail.com> Closesapache#1157 from hsaputra/cleanup_connection_classes_part2 and squashes the following commits: 4be6906 [Henry Saputra] Fix Spark Scala style for line over 100 chars. 85b24f7 [Henry Saputra] Cleanup on Connection and ConnectionManager classes part 2 while I was working at the code there to help IDE: 1. Remove unused imports 2. Remove parentheses in method calls that do not have side affect. 3. Add parentheses in method calls that do have side effect. 4. Change if-else check (via isInstanceOf) for Connection class type with Scala expression for consitency and cleanliness. 5. Remove semicolon 6. Remove extra spaces.
xiliu82 pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
… part 2 Cleanup on Connection, ConnectionManagerId, and ConnectionManager classes part 2 while I was working at the code there to help IDE: 1. Remove unused imports 2. Remove parentheses in method calls that do not have side affect. 3. Add parentheses in method calls that do have side effect or not simple get to object properties. 4. Change if-else check (via isInstanceOf) for Connection class type with Scala expression for consistency and cleanliness. 5. Remove semicolon 6. Remove extra spaces. 7. Remove redundant return for consistency Author: Henry Saputra <henry.saputra@gmail.com> Closesapache#1157 from hsaputra/cleanup_connection_classes_part2 and squashes the following commits: 4be6906 [Henry Saputra] Fix Spark Scala style for line over 100 chars. 85b24f7 [Henry Saputra] Cleanup on Connection and ConnectionManager classes part 2 while I was working at the code there to help IDE: 1. Remove unused imports 2. Remove parentheses in method calls that do not have side affect. 3. Add parentheses in method calls that do have side effect. 4. Change if-else check (via isInstanceOf) for Connection class type with Scala expression for consitency and cleanliness. 5. Remove semicolon 6. Remove extra spaces.
wangyum added a commit
that referenced
this pull request
May 26, 2023
#1157) * Update AdaptiveBloomFilterJoin.scala * Update AdaptiveBloomFilterJoin.scala
udaynpusa pushed a commit
to mapr/spark
that referenced
this pull request
Jan 30, 2024
mapr-devops pushed a commit
to mapr/spark
that referenced
this pull request
May 8, 2025
…ocumentation of build workflow MapR [DFDEVOPS-3022] Add an option to easily modify build images per component (apache#1153) MapR [SPARK-1225] Invoke deploy during first build MapR [SPARK-1237] "No such file or directory" when installing Spark 3.3.3 packages (apache#1157) Update Jenkinsfile top use main branch with shared-library MapR [SPARK-1225] Move dist dir to devops/dist Co-authored-by: Anatoliy Shevchuk <73828434+ashevchuk123@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup on Connection, ConnectionManagerId, and ConnectionManager classes part 2 while I was working at the code there to help IDE: