Uh oh!
There was an error while loading. Please reload this page.
[SPARK-13839][SQL] Defer input evaluation and fix Cast issue in IsNotNull filtering for Filter codegen - #11676
Closed
viirya wants to merge 1 commit into
Closed
[SPARK-13839][SQL] Defer input evaluation and fix Cast issue in IsNotNull filtering for Filter codegen#11676viirya wants to merge 1 commit into
viirya wants to merge 1 commit into
Conversation
SparkQA
commented
Mar 12, 2016
Test build #52997 has finished for PR 11676 at commit
|
SparkQA
commented
Mar 12, 2016
Test build #52998 has finished for PR 11676 at commit
|
viiryaforce-pushed
the
improve-filter-codegen
branch
from
March 12, 2016 12:39
c539777 to
6e4748bCompareSparkQA
commented
Mar 12, 2016
Test build #53003 has finished for PR 11676 at commit
|
viirya
commented
Mar 17, 2016
MemberAuthor
cc @davies Can you please review this? |
| case IsNotNull(a) if child.output.contains(a) => true | ||
| case IsNotNull(a) => | ||
| a match { | ||
| case Casts(a) if child.output.contains(a) => true |
Contributor
There was a problem hiding this comment.
We should not add these corner cases here, they should be handled by constraints.
MemberAuthor
There was a problem hiding this comment.
ok. I will send other PR for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/SPARK-13839
What changes were proposed in this pull request?
This PR improves Filter codegen by:
IsNotNull(a)to find the attributes needed to filter out null values. However, the expressionIsNotNull(Cast(a, dt))will not be checked by this. We should add pattern to find this.How was this patch tested?
Existing tests.