Uh oh!
There was an error while loading. Please reload this page.
[SPARK-13920][BUILD] MIMA checks should apply to @Experimental and @DeveloperAPI APIs - #11751
Closed
dongjoon-hyun wants to merge 2 commits into
Closed
[SPARK-13920][BUILD] MIMA checks should apply to @Experimental and @DeveloperAPI APIs#11751dongjoon-hyun wants to merge 2 commits into
dongjoon-hyun wants to merge 2 commits into
Conversation
| private val classLoader = Thread.currentThread().getContextClassLoader | ||
| private val mirror = runtimeMirror(classLoader) | ||
| // SPARK-13920: MIMA checks should apply to @Experimental and @DeveloperAPI APIs | ||
| private val ignoreExpDevApi = false |
Contributor
There was a problem hiding this comment.
Rather than adding an on/off switch, I'd just go ahead and completely remove these methods.
MemberAuthor
There was a problem hiding this comment.
Oh, I see. I'll remove all then. Thank you for fast review!
dongjoon-hyun
commented
Mar 16, 2016
MemberAuthor
@JoshRosen , I removed the legacy code and related comments now. |
JoshRosen
commented
Mar 16, 2016
Contributor
LGTM assuming that MiMa checks pass. |
dongjoon-hyun
commented
Mar 16, 2016
MemberAuthor
Thank you. |
rxin
commented
Mar 16, 2016
Contributor
Mima passed. I'm going to merge this. Thanks! |
dongjoon-hyun
commented
Mar 16, 2016
MemberAuthor
Thank you, @rxin ! |
SparkQA
commented
Mar 16, 2016
Test build #53270 has finished for PR 11751 at commit
|
SparkQA
commented
Mar 16, 2016
Test build #53279 has finished for PR 11751 at commit
|
roygao94 pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…eveloperAPI APIs ## What changes were proposed in this pull request? We are able to change `Experimental` and `DeveloperAPI` API freely but also should monitor and manage those API carefully. This PR for [SPARK-13920](https://issues.apache.org/jira/browse/SPARK-13920) enables MiMa check and adds filters for them. ## How was this patch tested? Pass the Jenkins tests (including MiMa). Author: Dongjoon Hyun <dongjoon@apache.org> Closesapache#11751 from dongjoon-hyun/SPARK-13920.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We are able to change
@Experimentaland@DeveloperAPIAPI freely but also should monitor and manage those API carefully. This PR for SPARK-13920 enables MiMa check and adds filters for them.How was this patch tested?
Pass the Jenkins tests (including MiMa).