Skip to content

[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive output - #1199

Closed
liancheng wants to merge 1 commit into
apache:masterfrom
liancheng:javaBigDecimal
Closed

[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive output#1199
liancheng wants to merge 1 commit into
apache:masterfrom
liancheng:javaBigDecimal

Conversation

@liancheng

@lianchengliancheng commented Jun 24, 2014

Copy link
Copy Markdown
Contributor

The BigDecimal branch in unwrap matches to scala.math.BigDecimal rather than java.math.BigDecimal.

@AmplabJenkins

AmplabJenkins commented Jun 24, 2014

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Jun 24, 2014

Copy link
Copy Markdown

Merged build started.

@AmplabJenkins

AmplabJenkins commented Jun 24, 2014

Copy link
Copy Markdown

Merged build finished.

@AmplabJenkins

AmplabJenkins commented Jun 24, 2014

Copy link
Copy Markdown

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16073/

@liancheng

liancheng commented Jun 25, 2014

Copy link
Copy Markdown
ContributorAuthor

I think the CachedTableSuite failed because TestData was not properly initialized. Is it related to running test cases in parallel?

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

Merged build triggered.

@liancheng

liancheng commented Jun 25, 2014

Copy link
Copy Markdown
ContributorAuthor

The problem is fixed by PR #1201, rebased to the most recent master.

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

Merged build started.

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

Merged build started.

@rxin

rxin commented Jun 25, 2014

Copy link
Copy Markdown
Contributor

Aren't we using Scala's BigDecimal?

@marmbrus

marmbrus commented Jun 25, 2014

Copy link
Copy Markdown
Contributor

@rxin we are probably using scala's but this code is unwrapping values that come from hive.

@rxin

rxin commented Jun 25, 2014

Copy link
Copy Markdown
Contributor

SGTM. We should probably switch to this: https://issues.apache.org/jira/browse/HIVE-6017 although it is a lower priority task (although for the purpose of API compatibility, maybe we want to make it higher priority0.

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

Merged build finished. All automated tests passed.

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16090/

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

Merged build finished.

@AmplabJenkins

AmplabJenkins commented Jun 25, 2014

Copy link
Copy Markdown

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16095/

@liancheng

liancheng commented Jun 25, 2014

Copy link
Copy Markdown
ContributorAuthor

Weird, I can't reproduce the test failure locally, and the failed test case seems completely unrelated to the change...

@liancheng

liancheng commented Jun 25, 2014

Copy link
Copy Markdown
ContributorAuthor

@marmbrus Would you mind to retest this? Thanks.

@liancheng

liancheng commented Jun 25, 2014

Copy link
Copy Markdown
ContributorAuthor

OK, I reproduced it locally by running PruningSuite after HiveCompatibilitySuite. Investigating.

@rxin

rxin commented Jun 25, 2014

Copy link
Copy Markdown
Contributor

I'm going to merge this first since the test is most likely a different problem.

asfgit pushed a commit that referenced this pull request Jun 25, 2014
@liancheng@rxin
[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive o…
65a559c
…utput
The `BigDecimal` branch in `unwrap` matches to `scala.math.BigDecimal` rather than `java.math.BigDecimal`.
Author: Cheng Lian <lian.cs.zju@gmail.com>
Closes#1199 from liancheng/javaBigDecimal and squashes the following commits:
e9bb481 [Cheng Lian] Should match java.math.BigDecimal when wnrapping Hive output
(cherry picked from commit 22036ae)
Signed-off-by: Reynold Xin <rxin@apache.org>
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@liancheng@pdeyhim
[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive o…
84b641b
…utput
The `BigDecimal` branch in `unwrap` matches to `scala.math.BigDecimal` rather than `java.math.BigDecimal`.
Author: Cheng Lian <lian.cs.zju@gmail.com>
Closesapache#1199 from liancheng/javaBigDecimal and squashes the following commits:
e9bb481 [Cheng Lian] Should match java.math.BigDecimal when wnrapping Hive output
@liancheng
liancheng deleted the javaBigDecimal branch June 25, 2014 20:36
@liancheng

liancheng commented Jun 25, 2014

Copy link
Copy Markdown
ContributorAuthor

@rxin Solved the test failure in PR #1221.

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@liancheng@conviva-zz
[BUGFIX][SQL] Should match java.math.BigDecimal when wnrapping Hive o…
a1c1d24
…utput
The `BigDecimal` branch in `unwrap` matches to `scala.math.BigDecimal` rather than `java.math.BigDecimal`.
Author: Cheng Lian <lian.cs.zju@gmail.com>
Closesapache#1199 from liancheng/javaBigDecimal and squashes the following commits:
e9bb481 [Cheng Lian] Should match java.math.BigDecimal when wnrapping Hive output
wangyum pushed a commit that referenced this pull request May 26, 2023
@allenmaGitHub Enterprise
[CARMEL-6490] Lots of unfinished state sql in the query log (#1199)
cb10771
* [CARMEL-6490] Lots of unfinished state sql in the query log
* Fix ut
mapr-devops pushed a commit to mapr/spark that referenced this pull request May 8, 2025
@ekrivokonmapr
MapR [SPARK-1286] Pyspark + Panda integration doesn't work (apache#1199)
4031507
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liancheng@AmplabJenkins@rxin@marmbrus