Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14215] [SQL] [PYSPARK] Support chained Python UDFs - #12014
Conversation
davies
commented
Mar 28, 2016
SparkQA
commented
Mar 28, 2016
Test build #54364 has finished for PR 12014 at commit
|
davies
commented
Mar 28, 2016
cc @cloud-fan |
hvanhovell
commented
Mar 28, 2016
@davies I think the JIRA number should be SPARK-14215: https://issues.apache.org/jira/browse/SPARK-14215 |
davies
commented
Mar 28, 2016
@hvanhovell Corrected, thanks! |
SparkQA
commented
Mar 28, 2016
Test build #54365 has finished for PR 12014 at commit
|
| # ---------------------------- User Defined Function ---------------------------------- | ||
| def _wrap_function(sc, func, returnType): |
There was a problem hiding this comment.
what's the point of creating a new _wrap_function here? To decrease the size of serialized python function?
There was a problem hiding this comment.
oh i see, we wanna chain the functions at python worker side.
SparkQA
commented
Mar 29, 2016
Test build #2705 has finished for PR 12014 at commit
|
cloud-fan
commented
Mar 29, 2016
Overall LGTM |
| row_based = read_int(infile) | ||
| num_commands = read_int(infile) | ||
| if row_based: | ||
| profiler = None # profiling is not supported for UDF |
There was a problem hiding this comment.
profiler seems need to be defined before this if block. The codes refer profiler later out of this block.
There was a problem hiding this comment.
The other branch also have profiler, so I think it's fine.
SparkQA
commented
Mar 29, 2016
Test build #2707 has finished for PR 12014 at commit
|
| case plan: EvaluatePython => plan | ||
| case plan: LogicalPlan if plan.resolved => | ||
| // Extract any PythonUDFs from the current operator. |
There was a problem hiding this comment.
We should update the comments the explain our new strategy of extracting and evaluating python udfs.
davies
commented
Mar 29, 2016
Merging this into master (the last commit only added comments). |
SparkQA
commented
Mar 29, 2016
Test build #54467 has finished for PR 12014 at commit
|
gatorsmile
commented
Mar 29, 2016
@davies It sounds you used a wrong JIRA number. |
davies
commented
Mar 29, 2016
@gatorsmile Corrected in PR, but the notification email is not updated. |
What changes were proposed in this pull request?
This PR brings the support for chained Python UDFs, for example
Also directly chained unary Python UDFs are put in single batch of Python UDFs, others may require multiple batches.
For example,
TODO: will support multiple unrelated Python UDFs in one batch (another PR).
How was this patch tested?
Added new unit tests for chained UDFs.