Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14470] Allow for overriding both httpclient and httpcore versions - #12245
Closed
atokhy wants to merge 1 commit into
Closed
[SPARK-14470] Allow for overriding both httpclient and httpcore versions#12245atokhy wants to merge 1 commit into
atokhy wants to merge 1 commit into
Conversation
atokhy
commented
Apr 7, 2016
Author
Reviewing related pull requests, this might conflict with: |
srowen
commented
Apr 7, 2016
Member
Although I think it's rare you'd want to set these differently, it's not a big deal to make this change, yes. |
srowen
commented
Apr 7, 2016
Member
Jenkins test this please |
SparkQA
commented
Apr 8, 2016
Test build #55258 has finished for PR 12245 at commit
|
JoshRosen
commented
Apr 8, 2016
Contributor
This seems fine to me as well. |
srowen
commented
Apr 8, 2016
Member
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This splits commons.httpclient.version from commons.httpcore.version, since these two versions do not necessarily have to be the same. This change may follow up with an up-to-date version of the httpclient/httpcore libraries.
The latest 4.3.x httpclient version as of writing is 4.3.6 and the latest 4.3.x httpcore version as of writing is 4.3.3. This change would be a prerequisite for potentially moving to this new bugfix version.
How was this patch tested?
no version change was made for httpclient/httpcore versions
mvn package