Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14504][SQL] Enable Oracle docker tests - #12270
Conversation
lresende
commented
Apr 9, 2016
This PR is dependent on PR #9893 |
SparkQA
commented
Apr 9, 2016
Test build #55419 has finished for PR 12270 at commit
|
JoshRosen
commented
Apr 11, 2016
I just merged #9893 so this should be ready for a rebase. |
JoshRosen
commented
Apr 15, 2016
Ping RE: rebase. |
SparkQA
commented
Apr 16, 2016
Test build #56018 has finished for PR 12270 at commit
|
SparkQA
commented
Apr 16, 2016
Test build #56019 has finished for PR 12270 at commit
|
SparkQA
commented
Apr 16, 2016
Test build #56021 has finished for PR 12270 at commit
|
SparkQA
commented
Apr 16, 2016
Test build #56024 has finished for PR 12270 at commit
|
SparkQA
commented
Apr 17, 2016
Test build #56030 has finished for PR 12270 at commit
|
SparkQA
commented
Apr 17, 2016
Test build #56031 has finished for PR 12270 at commit
|
SparkQA
commented
Apr 17, 2016
Test build #56042 has finished for PR 12270 at commit
|
SparkQA
commented
Apr 17, 2016
Test build #56062 has finished for PR 12270 at commit
|
lresende
commented
Apr 17, 2016
Jenkins, retest this |
lresende
commented
Apr 18, 2016
Jenkins, retest this please. |
There was a problem hiding this comment.
The jar was getting a warning for checksum on maven build, and failing on sbt build... let me try removing it now that I explicitly pointed where the jar is for sbt, wich might make this change obsolete.
SparkQA
commented
Apr 18, 2016
Test build #56087 has finished for PR 12270 at commit
|
SparkQA
commented
Apr 18, 2016
Test build #56110 has finished for PR 12270 at commit
|
JoshRosen
commented
Apr 18, 2016
I'm a bit skeptical of some of the build hacks needed for this but out of pragmatism I'm going to merge this now and will just remove these tests later if this turns out to be unreliable. |
rxin
commented
Apr 19, 2016
These tests are too flaky. I've already seen a few failures. We should disable them from the normal tests and maybe occasionally running them (via some trigger or just run it once before the release). |
rxin
commented
Apr 19, 2016
I just failed to build Spark locally once due to the docker oracle test. |
lresende
commented
Apr 19, 2016
@rxin, just trying to understand, is the oracle test the only one failing ? Or you are suggesting we move the whole docker based tests to a separate profile that would only run on Jenkins ? |
rxin
commented
Apr 19, 2016
I don't even think they should run on pull requests. Tests that require extensive external setup (or downloading things) in general are flaky. |
lresende
commented
Apr 19, 2016
@rxin Let me move them to a specific docker profile. But I would still run them on Jenkins, as the infrastructure is already setup there. |
They have been flaky and causing other pull requests to fail. That's why we shouldn't run them on Jenkins by default. |
rxin
commented
Apr 19, 2016
We can run them via some trigger phrase though. |
lresende
commented
Apr 19, 2016
Ok, I will work with @JoshRosen on the trigger part. |
## What changes were proposed in this pull request? Enable Oracle docker tests ## How was this patch tested? Existing tests Author: Luciano Resende <lresende@apache.org> Closesapache#12270 from lresende/oracle.
What changes were proposed in this pull request?
Enable Oracle docker tests
How was this patch tested?
Existing tests