Skip to content

[SPARK-14512][DOC] Add python example for QuantileDiscretizer - #12281

Closed
zhengruifeng wants to merge 2 commits into
apache:masterfrom
zhengruifeng:discret_pe
Closed

[SPARK-14512][DOC] Add python example for QuantileDiscretizer#12281
zhengruifeng wants to merge 2 commits into
apache:masterfrom
zhengruifeng:discret_pe

Conversation

@zhengruifeng

@zhengruifengzhengruifeng commented Apr 10, 2016

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Add the missing python example for QuantileDiscretizer

How was this patch tested?

manual tests

@SparkQA

SparkQA commented Apr 10, 2016

Copy link
Copy Markdown

Test build #55463 has finished for PR 12281 at commit acac4ae.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk

holdenk commented Apr 11, 2016

Copy link
Copy Markdown
Contributor

Looks good to me, confirmed the example runs as expected.

@holdenk

holdenk commented Apr 25, 2016

Copy link
Copy Markdown
Contributor

cc @davies ?

MLnick
MLnick reviewed May 5, 2016
View reviewed changes
Comment threadexamples/src/main/python/ml/quantile_discretizer_example.py Outdated

@MLnickMLnickMay 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples have been updated to use SparkSession, see e.g. https://github.com/apache/spark/blob/master/examples/src/main/python/ml/binarizer_example.py.

Also, there is a PR to indent the builder pattern #12911 so you should follow that style (also refer #12809)

@MLnick

MLnick commented May 5, 2016

Copy link
Copy Markdown
Contributor

@zhengruifeng sorry for the delay. The core of the example looks good, it just now needs to be updated to use SparkSession as per my comment. Thanks!

@MLnickMLnick mentioned this pull request May 5, 2016
Closed
@zhengruifeng

zhengruifeng commented May 5, 2016

Copy link
Copy Markdown
ContributorAuthor

@MLnick Updated. Thanks for review this.

@SparkQA

SparkQA commented May 5, 2016

Copy link
Copy Markdown

Test build #57882 has finished for PR 12281 at commit 9a29db5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yanboliang

yanboliang commented May 6, 2016

Copy link
Copy Markdown
Contributor

LGTM. Thanks!

@davies

davies commented May 6, 2016

Copy link
Copy Markdown
Contributor

Merging this into master and 2.0, thanks!

@asfgitasfgit closed this in 76ad04dMay 6, 2016
asfgit pushed a commit that referenced this pull request May 6, 2016
@zhengruifeng@davies
[SPARK-14512] [DOC] Add python example for QuantileDiscretizer
3f6a13c
## What changes were proposed in this pull request?
Add the missing python example for QuantileDiscretizer
## How was this patch tested?
manual tests
Author: Zheng RuiFeng <ruifengz@foxmail.com>
Closes#12281 from zhengruifeng/discret_pe.
(cherry picked from commit 76ad04d)
Signed-off-by: Davies Liu <davies.liu@gmail.com>
@zhengruifeng
zhengruifeng deleted the discret_pe branch May 7, 2016 23:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zhengruifeng@SparkQA@holdenk@MLnick@yanboliang@davies