Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14125] [SQL] Native DDL Support: Alter View - #12324
Closed
gatorsmile wants to merge 60 commits into
Closed
Conversation
SparkQA
commented
Apr 12, 2016
Test build #55595 has finished for PR 12324 at commit
|
gatorsmile
commented
Apr 13, 2016
MemberAuthor
| catalog.renameTable(oldName, newName) | ||
| Seq.empty[Row] | ||
| } | ||
Contributor
There was a problem hiding this comment.
nit: I left this line intentionally!
andrewor14
commented
Apr 13, 2016
Contributor
Looks great! Only minor comments. |
# Conflicts: # sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
SparkQA
commented
Apr 14, 2016
Test build #55782 has finished for PR 12324 at commit
|
| assert(!catalog.tableExists(TableIdentifier(oldViewName))) | ||
| assert(catalog.tableExists(TableIdentifier(newViewName))) | ||
| sql(s"DROP VIEW $newViewName") |
Contributor
There was a problem hiding this comment.
withView will help us drop the view at last.
MemberAuthor
There was a problem hiding this comment.
Sure, remove it now. Thanks!
cloud-fan
commented
Apr 14, 2016
Contributor
LGTM except some minor comments |
SparkQA
commented
Apr 14, 2016
Test build #55815 has finished for PR 12324 at commit
|
yhuai
commented
Apr 14, 2016
Contributor
Thanks. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to provide a native DDL support for the following three Alter View commands:
Based on the Hive DDL document:
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL
1. ALTER VIEW RENAME
Syntax:
2. ALTER VIEW SET TBLPROPERTIES
Syntax:
3. ALTER VIEW UNSET TBLPROPERTIES
Syntax:
How was this patch tested?
Added test cases to verify if it works properly.