Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14572] [Doc] Update config docs to allow -Xms in extraJavaOptions - #12333
[SPARK-14572] [Doc] Update config docs to allow -Xms in extraJavaOptions#12333dhruve wants to merge 2 commits into
Conversation
srowen
commented
Apr 12, 2016
I don't think this is useful to state, per JIRA. |
dhruve
commented
Apr 12, 2016
@srowen Even if we don't specify explicitly that -Xms can be set, we will need to update the doc which currently states that it is illegal to specify heap memory settings. |
tgravescs
commented
Apr 12, 2016
So I agree its not explicitly necessary to state Xms here, the only reason I think to mention it is the behavior is different from 1.X to 2.X, but there will be many other things different to so not a big deal to me on that. I do think some of the other text he added here is useful though and makes the descriptions across driver/executor/am more consistent. @srowen What do you think about just removing the sentence "However, specifying an initial heap
|
tgravescs
commented
Apr 12, 2016
@dhruve you should put the jira name int he pr description. Please see guidelines at: https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark#ContributingtoSpark-PullRequest |
srowen
commented
Apr 13, 2016
@tgravescs I agree with that suggestion |
dhruve
commented
Apr 13, 2016
I have updated the docs and removed the explicit mentions of Xms being allowed. |
srowen
commented
Apr 13, 2016
LGTM |
tgravescs
commented
Apr 14, 2016
Jenkins, test this please |
tgravescs
commented
Apr 14, 2016
+1, just doc changes so shouldn't really need jenkins, but kicked anyway. |
SparkQA
commented
Apr 14, 2016
Test build #55822 has finished for PR 12333 at commit
|
What changes were proposed in this pull request?
The configuration docs are updated to reflect the changes introduced with SPARK-12384. This allows the user to specify initial heap memory settings through the extraJavaOptions for executor, driver and am.
How was this patch tested?
The changes are tested in SPARK-12384. This is just documenting the changes made.