[SPARK-14589][SQL] Enhance DB2 JDBC Dialect docker tests by lresende · Pull Request #12348 · apache/spark

lresende · 2016-04-13T03:21:34Z

What changes were proposed in this pull request?

Enhance the DB2 JDBC Dialect docker tests as they seemed to have had some issues on previous merge causing some tests to fail.

How was this patch tested?

By running the integration tests locally.

SparkQA · 2016-04-13T05:05:24Z

Test build #55681 has finished for PR 12348 at commit 1f9d6fe.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- assert(types(0).equals(\"class java.lang.Integer\"))
- assert(types(1).equals(\"class java.lang.Integer\"))
- assert(types(2).equals(\"class java.lang.Long\"))
- assert(types(3).equals(\"class java.math.BigDecimal\"))
- assert(types(4).equals(\"class java.lang.Double\"))
- assert(types(5).equals(\"class java.lang.Double\"))
- assert(types(3).equals(\"class [B\"))

SparkQA · 2016-04-13T07:20:25Z

Test build #55690 has finished for PR 12348 at commit 7250fce.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- assert(types(0).equals(\"class java.lang.Integer\"))
- assert(types(1).equals(\"class java.lang.Integer\"))
- assert(types(2).equals(\"class java.lang.Long\"))
- assert(types(3).equals(\"class java.math.BigDecimal\"))
- assert(types(4).equals(\"class java.lang.Double\"))
- assert(types(5).equals(\"class java.lang.Double\"))
- assert(types(3).equals(\"class [B\"))

lresende · 2016-04-13T19:06:53Z

@JoshRosen please review, these are the merge issues I mentioned yesterday, and these changes are passing my local tests as well.

Add integration tests based on docker to test DB2 JDBC dialect support Author: Luciano Resende <lresende@apache.org> Closes#9893 from lresende/SPARK-10521.

SparkQA · 2016-04-14T03:40:00Z

Test build #55787 has finished for PR 12348 at commit b3e2a4f.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

lresende · 2016-04-14T03:45:07Z

Jenkins, retest this please.

SparkQA · 2016-04-14T05:39:41Z

Test build #55789 has finished for PR 12348 at commit b3e2a4f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-04-18T21:48:39Z

Test build #56143 has finished for PR 12348 at commit 47e2810.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

JoshRosen · 2016-04-18T22:50:17Z

Can you fix scalastyle?

SparkQA · 2016-04-19T01:33:18Z

Test build #56156 has finished for PR 12348 at commit ab950db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

lresende · 2016-04-19T03:03:38Z

@JoshRosen All good now.

lresende · 2016-04-21T03:39:14Z

@JoshRosen ping

srowen · 2016-05-03T11:50:00Z

Jenkins retest this please

SparkQA · 2016-05-03T13:43:34Z

Test build #57631 has finished for PR 12348 at commit ab950db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2016-05-04T22:31:15Z

Test build #57797 has finished for PR 12348 at commit 83ac475.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen · 2016-05-05T09:54:26Z

This test is ignored now anyway, and given @lresende 's confidence this actually gets it working, LGTM

## What changes were proposed in this pull request? Enhance the DB2 JDBC Dialect docker tests as they seemed to have had some issues on previous merge causing some tests to fail. ## How was this patch tested? By running the integration tests locally. Author: Luciano Resende <lresende@apache.org> Closes#12348 from lresende/SPARK-14589. (cherry picked from commit 1044302) Signed-off-by: Sean Owen <sowen@cloudera.com>

srowen · 2016-05-05T09:55:15Z

Merged to master/2.0

## What changes were proposed in this pull request? Create a maven profile for executing the docker integration tests using maven Remove docker integration tests from main sbt build Update documentation on how to run docker integration tests from sbt ## How was this patch tested? Manual test of the docker integration tests as in : mvn -Pdocker-integration-tests -pl :spark-docker-integration-tests_2.11 compile test ## Other comments Note that the the DB2 Docker Tests are still disabled as there is a kernel version issue on the AMPLab Jenkins slaves and we would need to get them on the right level before enabling those tests. They do run ok locally with the updates from PR #12348 Author: Luciano Resende <lresende@apache.org> Closes#12508 from lresende/docker.

## What changes were proposed in this pull request? Create a maven profile for executing the docker integration tests using maven Remove docker integration tests from main sbt build Update documentation on how to run docker integration tests from sbt ## How was this patch tested? Manual test of the docker integration tests as in : mvn -Pdocker-integration-tests -pl :spark-docker-integration-tests_2.11 compile test ## Other comments Note that the the DB2 Docker Tests are still disabled as there is a kernel version issue on the AMPLab Jenkins slaves and we would need to get them on the right level before enabling those tests. They do run ok locally with the updates from PR #12348 Author: Luciano Resende <lresende@apache.org> Closes#12508 from lresende/docker. (cherry picked from commit a03c5e6) Signed-off-by: Sean Owen <sowen@cloudera.com>

lresende force-pushed the SPARK-14589 branch from 1f9d6fe to 7250fceCompare April 13, 2016 05:21

lresende referenced this pull request Apr 14, 2016
[SPARK-10521][SQL] Utilize Docker for test DB2 JDBC Dialect support
94de630
Add integration tests based on docker to test DB2 JDBC dialect support Author: Luciano Resende <lresende@apache.org> Closes#9893 from lresende/SPARK-10521.

lresende force-pushed the SPARK-14589 branch from b3e2a4f to 47e2810Compare April 18, 2016 21:43

lresende force-pushed the SPARK-14589 branch from 47e2810 to ab950dbCompare April 18, 2016 23:32

lresende added 2 commits May 4, 2016 12:08

[SPARK-14589][SQL] Enhance DB2 JDBC Dialect docker tests
a4c2961

[SPARK-14589][SQL] Enhance DB2 repository definition on SparkBuild
83ac475

lresende force-pushed the SPARK-14589 branch from ab950db to 83ac475Compare May 4, 2016 20:35

lresende mentioned this pull request May 4, 2016
[SPARK-14738][BUILD] Separate docker integration tests from main build #12508
Closed

asfgit closed this in 1044302May 5, 2016

lresende deleted the SPARK-14589 branch May 7, 2016 01:17

Uh oh!

Conversation

lresende commented Apr 13, 2016

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

SparkQA commented Apr 13, 2016

Uh oh!

SparkQA commented Apr 13, 2016

Uh oh!

lresende commented Apr 13, 2016

Uh oh!

SparkQA commented Apr 14, 2016

Uh oh!

lresende commented Apr 14, 2016

Uh oh!

SparkQA commented Apr 14, 2016

Uh oh!

SparkQA commented Apr 18, 2016

Uh oh!

JoshRosen commented Apr 18, 2016

Uh oh!

SparkQA commented Apr 19, 2016

Uh oh!

lresende commented Apr 19, 2016

Uh oh!

lresende commented Apr 21, 2016

Uh oh!

srowen commented May 3, 2016

Uh oh!

SparkQA commented May 3, 2016

Uh oh!

SparkQA commented May 4, 2016

Uh oh!

srowen commented May 5, 2016

Uh oh!

srowen commented May 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants