Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14625] TaskUIData and ExecutorUIData shouldn't be case classes - #12386
Closed
rxin wants to merge 1 commit into
Closed
[SPARK-14625] TaskUIData and ExecutorUIData shouldn't be case classes#12386rxin wants to merge 1 commit into
rxin wants to merge 1 commit into
Conversation
rxin
commented
Apr 14, 2016
ContributorAuthor
cc @cloud-fan for review |
cloud-fan
commented
Apr 14, 2016
Contributor
LGTM |
SparkQA
commented
Apr 14, 2016
Test build #55803 has finished for PR 12386 at commit
|
rxin
commented
Apr 14, 2016
ContributorAuthor
Thanks - merging in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I was trying to understand the accumulator and metrics update source code and these two classes don't really need to be case classes. It would also be more consistent with other UI classes if they are not case classes. This is part of my bigger effort to simplify accumulators and task metrics.
How was this patch tested?
This is a straightforward refactoring without behavior change.