Skip to content

[SPARK-14640] Add @DeveloperApi on PythonUserDefinedType - #12401

Closed
joan38 wants to merge 1 commit into
apache:masterfrom
joan38:SPARK-14640-PythonUserDefinedType
Closed

[SPARK-14640] Add @DeveloperApi on PythonUserDefinedType#12401
joan38 wants to merge 1 commit into
apache:masterfrom
joan38:SPARK-14640-PythonUserDefinedType

Conversation

@joan38

@joan38joan38 commented Apr 14, 2016

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Add @DeveloperApi on PythonUserDefinedType

@SparkQA

Copy link
Copy Markdown

Test build #55838 has finished for PR 12401 at commit ed200fd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14

Copy link
Copy Markdown
Contributor

In general @DeveloperApis are only used for public classes. What is the motivation for adding this here?

@joan38

joan38 commented Apr 18, 2016

Copy link
Copy Markdown
ContributorAuthor

@andrewor14 Sorry I've been confused by the ::DeveloperApi:: in comments.
Should we remove ::DeveloperApi:: from the scaladoc then?

@andrewor14

Copy link
Copy Markdown
Contributor

Oh now I see why you did that. Yeah it doesn't even make sense to add a ::DeveloperApi:: to something without an annotation. I would remove that comment.

@joan38

Copy link
Copy Markdown
ContributorAuthor

Cheers @andrewor14 for the clarification. I will do a PR for that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@joan38@SparkQA@andrewor14