Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14662] LinearRegressionModel use default parameters if yStd is 0 - #12415
Closed
shkdee wants to merge 1 commit into
Closed
[SPARK-14662] LinearRegressionModel use default parameters if yStd is 0#12415shkdee wants to merge 1 commit into
shkdee wants to merge 1 commit into
Conversation
In the (rare) case where yStd is 0 in LinearRegression, parameters are not copied immediately to the created LinearRegressionModel instance, but they should (as in all other cases), because now the default column names are used in and returned by model.findSummaryModelAndPredictionCol(), which leads to schema validation errors.
AmplabJenkins
commented
Apr 15, 2016
Can one of the admins verify this patch? |
yanboliang
commented
Apr 15, 2016
Contributor
@shkdee This PR makes sense. Could you create a JIRA and add test case for this issue? |
yanboliang
commented
Apr 19, 2016
Contributor
@shkdee Could you add test case for this issue? Thanks. |
jkbradley
commented
Aug 29, 2016
Member
It looks like this was fixed in SPARK-15339, so can you please close this issue? Thanks! |
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This PR proposes to close some stale PRs and ones suggested to be closed by committer(s) Closesapache#12415Closesapache#14765Closesapache#15118Closesapache#15184Closesapache#15183Closesapache#9440Closesapache#15023Closesapache#14643Closesapache#14827 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#15198 from HyukjinKwon/stale-prs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the (rare) case where yStd is 0 in LinearRegression, parameters are not copied immediately to the created LinearRegressionModel instance, but they should (as in all other cases), because now the default column names are used in and returned by model.findSummaryModelAndPredictionCol(), which leads to schema validation errors.
How was this patch tested?
some simple manual tests