Skip to content

[Spark-14687][Core][SQL][MLlib] Call path.getFileSystem(conf) instead of call FileSystem.get(conf) - #12450

Closed
lw-lin wants to merge 1 commit into
apache:masterfrom
lw-lin:fix-fs-get
Closed

[Spark-14687][Core][SQL][MLlib] Call path.getFileSystem(conf) instead of call FileSystem.get(conf)#12450
lw-lin wants to merge 1 commit into
apache:masterfrom
lw-lin:fix-fs-get

Conversation

@lw-lin

@lw-linlw-lin commented Apr 17, 2016

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

  • replaced FileSystem.get(conf) calls with path.getFileSystem(conf)

How was this patch tested?

N/A

@SparkQA

SparkQA commented Apr 17, 2016

Copy link
Copy Markdown

Test build #56044 has finished for PR 12450 at commit feefa8d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen reviewed Apr 17, 2016
View reviewed changes
Comment threadsql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
dataFrameBuilder: Array[String] => DataFrame) extends Source with Logging {

private val fs = FileSystem.get(sqlContext.sparkContext.hadoopConfiguration)
private val fs = new Path(path).getFileSystem(sqlContext.sparkContext.hadoopConfiguration)

@srowensrowenApr 17, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM pending tests. I suppose this could even be fetched in the one place it's used later during the method call rather than hold on to a reference, but, I can't recall a specific reason it's bad to hold onto a FileSystem handle, so, leave it as you've done I think.

@srowen

srowen commented Apr 17, 2016

Copy link
Copy Markdown
Member

Jenkins retest this please

@SparkQA

SparkQA commented Apr 17, 2016

Copy link
Copy Markdown

Test build #56051 has finished for PR 12450 at commit feefa8d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@lw-lin

lw-lin commented Apr 18, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Some flaky tests -- not caused by this PR.

Jenkins retest this please

@SparkQA

SparkQA commented Apr 18, 2016

Copy link
Copy Markdown

Test build #56077 has finished for PR 12450 at commit feefa8d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@lw-lin

lw-lin commented Apr 19, 2016•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Some flaky tests -- not caused by this PR.

Jenkins retest this please

@SparkQA

SparkQA commented Apr 19, 2016

Copy link
Copy Markdown

Test build #56175 has finished for PR 12450 at commit feefa8d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen

srowen commented Apr 20, 2016

Copy link
Copy Markdown
Member

Merged to master

@lw-lin

lw-lin commented Apr 20, 2016

Copy link
Copy Markdown
ContributorAuthor

@srowen thank you for the review & merging :-)

@lw-lin
lw-lin deleted the fix-fs-get branch April 20, 2016 12:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lw-lin@SparkQA@srowen