Uh oh!
There was an error while loading. Please reload this page.
[Minor] [ML] [PySpark] Fix omissive params which should use TypeConverter - #12529
[Minor] [ML] [PySpark] Fix omissive params which should use TypeConverter#12529yanboliang wants to merge 1 commit into
Conversation
SparkQA
commented
Apr 20, 2016
Test build #56359 has finished for PR 12529 at commit
|
holdenk
commented
Apr 20, 2016
Minor nit: Maybe s/omissive/missing/ for clarity while reading the title? |
jkbradley
commented
Apr 20, 2016
I'm fine with removing expectedType. I brought this up here [https://github.com//pull/12480], but that comment will probably be buried now. I'll create a JIRA: [https://issues.apache.org/jira/browse/SPARK-14768] |
jkbradley
commented
Apr 20, 2016
@yanboliang Thanks for the PR, LGTM (though I agree with Holden's title nit). |
What changes were proposed in this pull request?
#11663 adds type conversion functionality for parameters in Pyspark. This PR find out the omissive
Paramthat did not pass correspondingTypeConverterargument and fix them. After this PR, all params in pyspark/ml/ usedTypeConverter.How was this patch tested?
Existing tests.
cc @jkbradley@sethah