Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14772][ML,PySpark]Python ML Params.copy treats uid, paramMaps … - #12888
[SPARK-14772][ML,PySpark]Python ML Params.copy treats uid, paramMaps …#12888hujy wants to merge 3 commits into
Conversation
…differently than Scala
| return self._defaultParamMap[param] | ||
| @since("1.4.0") | ||
| def extractParamMap(self, extra=None): |
holdenk
commented
May 4, 2016
Thanks for tackling this issue :) For a better understanding - is there a reason why adding a flag for this behaviour instead of just changing it (since it is a bug) - do we expect people to want to explicitly copy the default param map in this way? |
holdenk
commented
May 4, 2016
Also it would be good to have tests to ensure the change has the desired impact. |
hujy
commented
May 5, 2016
@holdenk, I'm checking with @jkbradley about "respect the difference between defaultParamMap and paramMap" in the requirement. The new input parameter is optional and will not impact the user not want to copy default param. : ) |
hujy
commented
May 13, 2016
ok with test |
AmplabJenkins
commented
May 25, 2016
Can one of the admins verify this patch? |
holdenk
commented
Oct 7, 2016
So to trigger the test we will need one of the committers - e.g. @davies is one of the more active Python committers (although he has been busy lately) so we can also check with @MLnick . It would also be nice if you could document the param (even if we don't expect the user to use it - its useful to have it noted for other developers and so users know not to worry about it). |
jkbradley
commented
Feb 24, 2017
@hujy Thank you for sending this PR, and apologies for not seeing it earlier. Since the other PR for this JIRA is ready to merge, could you please close this issue? Thanks again! |
Closesapache#16819Closesapache#13467Closesapache#16083Closesapache#17135Closesapache#8785Closesapache#16278Closesapache#16997Closesapache#17073Closesapache#17220 Added: Closesapache#12059Closesapache#12524Closesapache#12888Closesapache#16061 Author: Sean Owen <sowen@cloudera.com> Closesapache#17386 from srowen/StalePRs.
What changes were proposed in this pull request?
The patch referenced SPARK-14772
After apply this patch, user can choose to just copy the default param map or the param map.
How was this patch tested?
Unit test, test locally.