Skip to content

[SPARK-15172][ML] Explicitly tell user initial coefficients is ignored when size mismatch happened in LogisticRegression - #12948

Closed
dding3 wants to merge 3 commits into
apache:masterfrom
dding3:master
Closed

[SPARK-15172][ML] Explicitly tell user initial coefficients is ignored when size mismatch happened in LogisticRegression#12948
dding3 wants to merge 3 commits into
apache:masterfrom
dding3:master

Conversation

@dding3

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Explicitly tell user initial coefficients is ignored if its size doesn't match expected size in LogisticRegression

How was this patch tested?

local build

@srowen

Copy link
Copy Markdown
Member

Jenkins test this please

@srowen

Copy link
Copy Markdown
Member

Seems OK to me. This is too trivial for a JIRA, but could have a better title here

@SparkQA

Copy link
Copy Markdown

Test build #57973 has finished for PR 12948 at commit 54cfaed.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dding3dding3 changed the title [SPARK-15172][ML] Improve LogisticRegression warning message[SPARK-15172][ML] Explicitly tell user initial coefficients is ignored when size mismatch happened in LogisticRegressionMay 7, 2016
@srowen

Copy link
Copy Markdown
Member

Jenkins retest this please

@SparkQA

Copy link
Copy Markdown

Test build #58097 has finished for PR 12948 at commit f9b88de.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dding3

Copy link
Copy Markdown
ContributorAuthor

Jenkins retest this please

1 similar comment
@srowen

Copy link
Copy Markdown
Member

Jenkins retest this please

@srowen

Copy link
Copy Markdown
Member

Jenkins add to whitelist

@SparkQA

Copy link
Copy Markdown

Test build #58129 has finished for PR 12948 at commit 1b33456.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen

Copy link
Copy Markdown
Member

Merged to master

@asfgitasfgit closed this in a78fbfaMay 9, 2016
@mengxr

Copy link
Copy Markdown
Contributor

Merged into branch-2.0 as well.

asfgit pushed a commit that referenced this pull request May 20, 2016
…d when size mismatch happened in LogisticRegression
## What changes were proposed in this pull request?
Explicitly tell user initial coefficients is ignored if its size doesn't match expected size in LogisticRegression
## How was this patch tested?
local build
Author: dding3 <dingding@dingding-ubuntu.sh.intel.com>
Closes#12948 from dding3/master.
(cherry picked from commit a78fbfa)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dding3@srowen@SparkQA@mengxr