Skip to content

[SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS - #1319

Closed
nevillelyh wants to merge 1 commit into
apache:masterfrom
nevillelyh:gh/SPARK-1977
Closed

[SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS#1319
nevillelyh wants to merge 1 commit into
apache:masterfrom
nevillelyh:gh/SPARK-1977

Conversation

@nevillelyh

@nevillelyhnevillelyh commented Jul 7, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@AmplabJenkins

AmplabJenkins commented Jul 7, 2014

Copy link
Copy Markdown

Can one of the admins verify this patch?

@mengxr

mengxr commented Jul 7, 2014

Copy link
Copy Markdown
Contributor

Jenkins, add to whitelist.

@mengxr

mengxr commented Jul 7, 2014

Copy link
Copy Markdown
Contributor

Jenkins, test this please.

@AmplabJenkins

AmplabJenkins commented Jul 7, 2014

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Jul 7, 2014

Copy link
Copy Markdown

Merged build started.

mengxr
mengxr reviewed Jul 7, 2014
View reviewed changes
Comment threadexamples/src/main/scala/org/apache/spark/examples/mllib/MovieLensALS.scala Outdated

@mengxrmengxrJul 7, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we import scala.collection.mutable here and use mutable.BitSet in the Kryo registrator?

@nevillelyh

nevillelyh commented Jul 7, 2014

Copy link
Copy Markdown
ContributorAuthor

@mengxr just realized that chill 0.4.0 was just released, will bump version instead of this fix.

@mengxr

mengxr commented Jul 7, 2014

Copy link
Copy Markdown
Contributor

Bumping the version requires more tasks to do, e.g., dependency/license check, regression check, etc. I would rather register mutable.BitSet for this PR.

@nevillelyh

nevillelyh commented Jul 7, 2014

Copy link
Copy Markdown
ContributorAuthor

Fair enough :)
Changed to import scala.collection.mutable instead.

@AmplabJenkins

AmplabJenkins commented Jul 7, 2014

Copy link
Copy Markdown

Merged build triggered.

@AmplabJenkins

AmplabJenkins commented Jul 7, 2014

Copy link
Copy Markdown

Merged build started.

@AmplabJenkins

AmplabJenkins commented Jul 7, 2014

Copy link
Copy Markdown

Merged build finished. All automated tests passed.

@AmplabJenkins

AmplabJenkins commented Jul 7, 2014

Copy link
Copy Markdown

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16381/

@asfgitasfgit closed this in f7ce1b3Jul 7, 2014
asfgit pushed a commit that referenced this pull request Jul 7, 2014
@nevillelyh@mengxr
[SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS
5044ba6
Author: Neville Li <neville@spotify.com>
Closes#1319 from nevillelyh/gh/SPARK-1977 and squashes the following commits:
1f0a355 [Neville Li] [SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS
(cherry picked from commit f7ce1b3)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr

mengxr commented Jul 7, 2014

Copy link
Copy Markdown
Contributor

Merged. Thanks!

@AmplabJenkins

AmplabJenkins commented Jul 7, 2014

Copy link
Copy Markdown

Merged build finished. All automated tests passed.

@AmplabJenkins

AmplabJenkins commented Jul 7, 2014

Copy link
Copy Markdown

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16386/

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@nevillelyh@conviva-zz
[SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS
39a5b9f
Author: Neville Li <neville@spotify.com>
Closesapache#1319 from nevillelyh/gh/SPARK-1977 and squashes the following commits:
1f0a355 [Neville Li] [SPARK-1977][MLLIB] register mutable BitSet in MovieLenseALS
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nevillelyh@AmplabJenkins@mengxr