Uh oh!
There was an error while loading. Please reload this page.
[SPARK-11827][SQL] Fix compilation against Java 7 - #13233
Closed
ted-yu wants to merge 1 commit into
Closed
Conversation
rxin
commented
May 20, 2016
Contributor
@srowen are you saying this fix is not sufficient? |
srowen
commented
May 20, 2016
Member
Yes, this fails to check that the value fits in a long and will silently truncate. |
ted-yu
commented
May 20, 2016
Author
Should reflection be used :-) |
srowen
commented
May 20, 2016
Member
No, it's as simple as the fix in #13223 This PR should be closed. |
SparkQA
commented
May 20, 2016
Test build #59028 has finished for PR 13233 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes compilation error against Java 7:
How was this patch tested?
Existing tests.