SPARK-2482: Resolve sbt warnings during build by witgo · Pull Request #1330 · apache/spark

witgo · 2014-07-08T17:07:40Z

At the same time, import the scala.language.postfixOps and org.scalatest.time.SpanSugar._ cause scala.language.postfixOps doesn't work

AmplabJenkins · 2014-07-08T17:11:07Z

Merged build triggered.

AmplabJenkins · 2014-07-08T17:11:13Z

Merged build started.

vanzin · 2014-07-08T17:14:46Z

LGTM if tests pass.

srowen · 2014-07-08T17:31:25Z

Were all of those imports being removed not required after all to avoid warnings? as long as that's the case (i.e. no build warnings) yes this is great IMHO.

AmplabJenkins · 2014-07-08T17:57:36Z

Merged build finished. All automated tests passed.

AmplabJenkins · 2014-07-08T17:57:36Z

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16410/

pwendell · 2014-07-15T20:07:38Z

Jenkins, retest this pleae.

pwendell · 2014-07-15T20:07:43Z

Jenkins, retest this please.

SparkQA · 2014-07-15T20:12:48Z

QA tests have started for PR 1330. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16690/consoleFull

pwendell · 2014-07-15T23:14:56Z

Could you paste exactly which warnings you are eliminating? I don't see any warnings in our master jenkins build that seem relevant to these changes.

witgo · 2014-07-16T02:41:14Z

As a result of #772. The master has fixed this problem. But we should remove this line <arg>-language:postfixOps</arg> in pom.xml#L807. Once we remove this line.The problem will be back.
May have a look the discussion in #1069

SparkQA · 2014-07-16T02:47:58Z

QA tests have started for PR 1330. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16702/consoleFull

SparkQA · 2014-07-16T04:32:28Z

QA results for PR 1330:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16702/consoleFull

SparkQA · 2014-08-04T14:54:15Z

QA tests have started for PR 1330. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17855/consoleFull

SparkQA · 2014-08-04T15:53:53Z

QA results for PR 1330:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17855/consoleFull

andrewor14 · 2014-08-25T21:48:29Z

test this please

srowen · 2014-08-25T21:53:49Z

This is a sort of duplicate of #1069 @witgo this was opened a few times?

From the discussion, I am not clear this should be committed. The preferred practice here seems to be to import scala.language.postfixOps rather than use a compiler flag. This does the opposite.

In fact the compiler flag -language:postfixOps should be removed, which would then make these imports being removed important.

witgo · 2014-08-26T02:06:48Z

@andrewor14 , @srowen
This is mainly to solve the problem of importing the scala.language.postfixOps and org.scalatest.time.SpanSugar._ at the same time.

SparkQA · 2014-09-03T14:34:29Z

QA tests have started for PR 1330 at commit 15d5ed3.

This patch merges cleanly.

SparkQA · 2014-09-03T15:36:03Z

QA tests have finished for PR 1330 at commit 15d5ed3.

This patch passes unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- protected trait YarnAllocateResponse

jkbradley · 2014-09-10T23:12:04Z

@witgo Hi, I was asked to take a look at this PR. I tested the current master vs. this PR merged with the master, and I actually found that this PR added postfix warnings for me. (No postfix warnings in the master, but several with this PR.) Could you please show the warnings you get, plus info on what might be causing those warnings on your system? Thanks!

witgo · 2014-09-11T02:14:41Z

The code has been updated.

witgo · 2014-09-11T02:23:21Z

@jkbradley I removed this parameter. The related discussion in #1069

SparkQA · 2014-09-11T02:52:53Z

QA tests have started for PR 1330 at commit 179ba61.

This patch merges cleanly.

SparkQA · 2014-09-11T03:54:17Z

QA tests have finished for PR 1330 at commit 179ba61.

This patch passes unit tests.
This patch merges cleanly.
This patch adds no public classes.

srowen · 2014-09-11T08:44:16Z

The net-net change for all of these overlapping PRs should be: remove the compiler flag, and, add the import everywhere that the warning occurs. If there are warnings after this PR, they need to be squashed with more imports.

witgo · 2014-09-11T08:51:02Z

No postfix warnings in 179ba61 .

jkbradley · 2014-09-11T19:10:54Z

@witgo Sorry, I had not realized that this had not been updated since the discussions. Just tested it, and it worked for me. LGTM

andrewor14 · 2014-09-12T01:44:10Z

Ok, I am merging this over the alternative PR #1323, which is now closed. Thanks to everyone who looked at this.

witgo changed the title ~~Resolve sbt warnings during build~~SPARK-2482: Resolve sbt warnings during buildJul 15, 2014

witgo mentioned this pull request Aug 4, 2014
Fix postfixOps warnings in the test suite #1323
Closed

witgo force-pushed the sbt_warnings3 branch from 41533b6 to 15d5ed3Compare September 3, 2014 14:29

Resolve sbt warnings during build
179ba61

witgo force-pushed the sbt_warnings3 branch from 15d5ed3 to 179ba61Compare September 11, 2014 02:13

witgo reviewed Sep 11, 2014
View reviewed changes

Comment threadpom.xml
witgoSep 11, 2014
Copy link
Copy Markdown
ContributorAuthor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkbradley I removed this parameter. The related discussion in #1069

asfgit closed this in 33c7a73Sep 12, 2014

witgo deleted the sbt_warnings3 branch September 12, 2014 01:57

Uh oh!

Conversation

witgo commented Jul 8, 2014

Uh oh!

AmplabJenkins commented Jul 8, 2014

Uh oh!

AmplabJenkins commented Jul 8, 2014

Uh oh!

vanzin commented Jul 8, 2014

Uh oh!

srowen commented Jul 8, 2014

Uh oh!

AmplabJenkins commented Jul 8, 2014

Uh oh!

AmplabJenkins commented Jul 8, 2014

Uh oh!

pwendell commented Jul 15, 2014

Uh oh!

pwendell commented Jul 15, 2014

Uh oh!

SparkQA commented Jul 15, 2014

Uh oh!

pwendell commented Jul 15, 2014

Uh oh!

witgo commented Jul 16, 2014

Uh oh!

SparkQA commented Jul 16, 2014

Uh oh!

SparkQA commented Jul 16, 2014

Uh oh!

SparkQA commented Aug 4, 2014

Uh oh!

SparkQA commented Aug 4, 2014

Uh oh!

andrewor14 commented Aug 25, 2014

Uh oh!

srowen commented Aug 25, 2014

Uh oh!

witgo commented Aug 26, 2014

Uh oh!

SparkQA commented Sep 3, 2014

Uh oh!

SparkQA commented Sep 3, 2014

Uh oh!

jkbradley commented Sep 10, 2014

Uh oh!

witgo commented Sep 11, 2014

Uh oh!

witgoSep 11, 2014

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Sep 11, 2014

Uh oh!

SparkQA commented Sep 11, 2014

Uh oh!

srowen commented Sep 11, 2014

Uh oh!

witgo commented Sep 11, 2014

Uh oh!

jkbradley commented Sep 11, 2014

Uh oh!

andrewor14 commented Sep 12, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants