Skip to content

[SPARK-15837][ML][PySpark]Word2vec python add maxsentence parameter - #13578

Closed
WeichenXu123 wants to merge 1 commit into
apache:masterfrom
WeichenXu123:word2vec_python_add_maxsentence
Closed

[SPARK-15837][ML][PySpark]Word2vec python add maxsentence parameter#13578
WeichenXu123 wants to merge 1 commit into
apache:masterfrom
WeichenXu123:word2vec_python_add_maxsentence

Conversation

@WeichenXu123

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Word2vec python add maxsentence parameter.

How was this patch tested?

Existing test.

@srowen

Copy link
Copy Markdown
Member

Seems OK

@WeichenXu123

WeichenXu123 commented Jun 9, 2016

Copy link
Copy Markdown
ContributorAuthor

@srowen Hi srowen, I have another similar PR #13558 which pass test on my machine, but the official test fail. It seems to be the test server's problem, can you help to check it ?

@SparkQA

Copy link
Copy Markdown

Test build #60237 has finished for PR 13578 at commit 57384a0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MLnick

Copy link
Copy Markdown
Contributor

LGTM

asfgit pushed a commit that referenced this pull request Jun 10, 2016
## What changes were proposed in this pull request?
Word2vec python add maxsentence parameter.
## How was this patch tested?
Existing test.
Author: WeichenXu <WeichenXu123@outlook.com>
Closes#13578 from WeichenXu123/word2vec_python_add_maxsentence.
(cherry picked from commit cdd7f5a)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen

Copy link
Copy Markdown
Member

Merged to master/2.0

@WeichenXu123
WeichenXu123 deleted the word2vec_python_add_maxsentence branch June 10, 2016 12:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@WeichenXu123@srowen@SparkQA@MLnick