Uh oh!
There was an error while loading. Please reload this page.
[SPARK-10258][DOC][ML] Add @Since annotations to ml.feature - #13641
[SPARK-10258][DOC][ML] Add @Since annotations to ml.feature#13641MLnick wants to merge 6 commits into
Conversation
3c8be11 to
bb43722CompareMLnick
commented
Jun 13, 2016
SparkQA
commented
Jun 13, 2016
Test build #60400 has finished for PR 13641 at commit
|
SparkQA
commented
Jun 13, 2016
Test build #60401 has finished for PR 13641 at commit
|
SparkQA
commented
Jun 13, 2016
Test build #60402 has finished for PR 13641 at commit
|
There was a problem hiding this comment.
Not due to this PR, but here seems like a typo since MaxAbsScaler was added after 1.6.0.
There was a problem hiding this comment.
And in L174 and L177 should also be @Since("2.0.0").
yanboliang
commented
Jun 16, 2016
@MLnick I found you did not add |
9978afa to
86ab82bCompareSparkQA
commented
Jun 17, 2016
Test build #60694 has finished for PR 13641 at commit
|
MLnick
commented
Jun 17, 2016
@yanboliang thanks - updated. I also added annotations on overridden methods Let me know if I missed anything! |
SparkQA
commented
Jun 17, 2016
Test build #60699 has finished for PR 13641 at commit
|
SparkQA
commented
Jun 17, 2016
Test build #60700 has finished for PR 13641 at commit
|
| * the vector to multiply with input vectors | ||
| * @group param | ||
| */ | ||
| @Since("1.4.0") |
There was a problem hiding this comment.
This uses the new Vector. So ideally it is since 2.0.0. I'm not sure about whether we should change the class since version to 2.0 as well.
There was a problem hiding this comment.
good point, and also yeah technically all unary transformers over Vector should probably be since 2.0.0. Will update
@mengxr@yanboliang I went ahead and bumped all |
SparkQA
commented
Jun 20, 2016
Test build #60842 has finished for PR 13641 at commit
|
This PR adds missing `Since` annotations to `ml.feature` package. Closes#8505. ## How was this patch tested? Existing tests. Author: Nick Pentreath <nickp@za.ibm.com> Closes#13641 from MLnick/add-since-annotations. (cherry picked from commit 37494a1) Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr I thought more about the I thought the concrete classes would be binary incompatible but I don't actually think that is the case - and I just tested this (master against commit immediately prior to e2efe05) and apart from I've created SPARK-16127 to track further annotations that need updating related to new |
This PR adds missing
@Sinceannotations toml.featurepackage.Closes#8505.
How was this patch tested?
Existing tests.