Uh oh!
There was an error while loading. Please reload this page.
[SPARK-16212][STREAMING][KAFKA] code cleanup from review feedback - #13908
Closed
koeninger wants to merge 4 commits into
Closed
[SPARK-16212][STREAMING][KAFKA] code cleanup from review feedback#13908koeninger wants to merge 4 commits into
koeninger wants to merge 4 commits into
Conversation
SparkQA
commented
Jun 26, 2016
Test build #61248 has finished for PR 13908 at commit
|
SparkQA
commented
Jun 26, 2016
Test build #61249 has finished for PR 13908 at commit
|
SparkQA
commented
Jun 26, 2016
Test build #61251 has finished for PR 13908 at commit
|
SparkQA
commented
Jun 29, 2016
Test build #61508 has finished for PR 13908 at commit
|
tdas
commented
Jun 30, 2016
Contributor
LGTM. Unless you plan to make more changes. |
koeninger
commented
Jun 30, 2016
ContributorAuthor
I don't plan to make any more changes... I kind of doubt feedback on your #13996 is going to result in any changes that would also apply to 0.8 |
Contributor
Cool. Merging this to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
code cleanup in kafka-0-8 to match suggested changes for kafka-0-10 branch
How was this patch tested?
unit tests