Uh oh!
There was an error while loading. Please reload this page.
[SPARK-16267][TEST] Replace deprecated CREATE TEMPORARY TABLE ... USING from testsuites. - #13956
Closed
dongjoon-hyun wants to merge 2 commits into
Closed
[SPARK-16267][TEST] Replace deprecated CREATE TEMPORARY TABLE ... USING from testsuites.#13956dongjoon-hyun wants to merge 2 commits into
CREATE TEMPORARY TABLE ... USING from testsuites.#13956dongjoon-hyun wants to merge 2 commits into
Conversation
| sql( | ||
| s""" | ||
| |CREATE TEMPORARY TABLE PEOPLE | ||
| |CREATE OR REPLACE TEMPORARY VIEW PEOPLE |
MemberAuthor
There was a problem hiding this comment.
This testsuite needs CREATE OR REPLACE.
SparkQA
commented
Jun 29, 2016
Test build #61422 has finished for PR 13956 at commit
|
CREATE TEMPORARY TABLE from testsuites.CREATE TEMPORARY TABLE ... USING from testsuites.dongjoon-hyun
commented
Jun 29, 2016
MemberAuthor
Could you review this PR, @srowen ? |
MemberAuthor
Hi, @rxin . Today, I faced the following irrelevant error in my other PR ( https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61479/consoleFull I think this PR can help the flaky testsuite since this PR replace it with |
rxin
commented
Jun 29, 2016
Contributor
Can you roll back the license whitespace changes? |
dongjoon-hyun
commented
Jun 29, 2016
MemberAuthor
Yep. I reverted the License indentation fixes. |
rxin
commented
Jun 29, 2016
Contributor
LGTM pending Jenkins. |
SparkQA
commented
Jun 30, 2016
Test build #61502 has finished for PR 13956 at commit
|
rxin
commented
Jun 30, 2016
Contributor
Merging in master/2.0. |
asfgit pushed a commit
that referenced
this pull request
Jun 30, 2016
…ING` from testsuites. ## What changes were proposed in this pull request? After SPARK-15674, `DDLStrategy` prints out the following deprecation messages in the testsuites. ``` 12:10:53.284 WARN org.apache.spark.sql.execution.SparkStrategies$DDLStrategy: CREATE TEMPORARY TABLE normal_orc_source USING... is deprecated, please use CREATE TEMPORARY VIEW viewName USING... instead ``` Total : 40 - JDBCWriteSuite: 14 - DDLSuite: 6 - TableScanSuite: 6 - ParquetSourceSuite: 5 - OrcSourceSuite: 2 - SQLQuerySuite: 2 - HiveCommandSuite: 2 - JsonSuite: 1 - PrunedScanSuite: 1 - FilteredScanSuite 1 This PR replaces `CREATE TEMPORARY TABLE` with `CREATE TEMPORARY VIEW` in order to remove the deprecation messages in the above testsuites except `DDLSuite`, `SQLQuerySuite`, `HiveCommandSuite`. The Jenkins results shows only remaining 10 messages. https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61422/consoleFull ## How was this patch tested? This is a testsuite-only change. Author: Dongjoon Hyun <dongjoon@apache.org> Closes#13956 from dongjoon-hyun/SPARK-16267. (cherry picked from commit 831a04f) Signed-off-by: Reynold Xin <rxin@databricks.com>
dongjoon-hyun
commented
Jun 30, 2016
MemberAuthor
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After SPARK-15674,
DDLStrategyprints out the following deprecation messages in the testsuites.Total : 40
This PR replaces
CREATE TEMPORARY TABLEwithCREATE TEMPORARY VIEWin order to remove the deprecation messages in the above testsuites exceptDDLSuite,SQLQuerySuite,HiveCommandSuite.The Jenkins results shows only remaining 10 messages.
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61422/consoleFull
How was this patch tested?
This is a testsuite-only change.