Uh oh!
There was an error while loading. Please reload this page.
[SPARK-15954][SQL] Disable loading test tables in Python tests - #14005
Closed
rxin wants to merge 2 commits into
Closed
[SPARK-15954][SQL] Disable loading test tables in Python tests#14005rxin wants to merge 2 commits into
rxin wants to merge 2 commits into
Conversation
rxin
commented
Jun 30, 2016
ContributorAuthor
The diff is a lot smaller when ignoring whitespaces: https://github.com/apache/spark/pull/14005/files?w=1 Most of the changes are just some indentation change. |
holdenk
commented
Jun 30, 2016
Contributor
Great approach, I mentioned I had a similar approach available in the other PR #13737 (comment) to fix this (adding a flag to disable loading the tables) (although mine used a lazy val and only had the if around register) but looks functional equivalent. Note: I ran the scala hive tests locally and they failed, I think that the default should be to load the tables. You can fix it here or I can push my version. But other than that LGTM pending tests passing. |
rxin
commented
Jun 30, 2016
ContributorAuthor
ah yes default should definitely be true. let me fix that. |
SparkQA
commented
Jun 30, 2016
Test build #61579 has finished for PR 14005 at commit
|
holdenk
commented
Jun 30, 2016
Contributor
LGTM pending tests. I'll go ahead and close my original PR. cc @MLnick and @sameeragarwal . |
SparkQA
commented
Jul 1, 2016
Test build #61582 has finished for PR 14005 at commit
|
rxin
commented
Jul 1, 2016
ContributorAuthor
Merging in master/2.0. |
asfgit pushed a commit
that referenced
this pull request
Jul 1, 2016
## What changes were proposed in this pull request? This patch introduces a flag to disable loading test tables in TestHiveSparkSession and disables that in Python. This fixes an issue in which python/run-tests would fail due to failure to load test tables. Note that these test tables are not used outside of HiveCompatibilitySuite. In the long run we should probably decouple the loading of test tables from the test Hive setup. ## How was this patch tested? This is a test only change. Author: Reynold Xin <rxin@databricks.com> Closes#14005 from rxin/SPARK-15954. (cherry picked from commit 38f4d6f) Signed-off-by: Reynold Xin <rxin@databricks.com>
asfgit pushed a commit
that referenced
this pull request
Aug 31, 2016
…skipped always ## What changes were proposed in this pull request? Currently, `HiveContext` in SparkR is not being tested and always skipped. This is because the initiation of `TestHiveContext` is being failed due to trying to load non-existing data paths (test tables). This is introduced from #14005 This enables the tests with SparkR. ## How was this patch tested? Manually, **Before** (on Mac OS) ``` ... Skipped ------------------------------------------------------------------------ 1. create DataFrame from RDD (test_sparkSQL.R#200) - Hive is not build with SparkSQL, skipped 2. test HiveContext (test_sparkSQL.R#1041) - Hive is not build with SparkSQL, skipped 3. read/write ORC files (test_sparkSQL.R#1748) - Hive is not build with SparkSQL, skipped 4. enableHiveSupport on SparkSession (test_sparkSQL.R#2480) - Hive is not build with SparkSQL, skipped 5. sparkJars tag in SparkContext (test_Windows.R#21) - This test is only for Windows, skipped ... ``` **After** (on Mac OS) ``` ... Skipped ------------------------------------------------------------------------ 1. sparkJars tag in SparkContext (test_Windows.R#21) - This test is only for Windows, skipped ... ``` Please refer the tests below (on Windows) - Before: https://ci.appveyor.com/project/HyukjinKwon/spark/build/45-test123 - After: https://ci.appveyor.com/project/HyukjinKwon/spark/build/46-test123 Author: hyukjinkwon <gurwls223@gmail.com> Closes#14889 from HyukjinKwon/SPARK-17326. (cherry picked from commit 50bb142) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
asfgit pushed a commit
that referenced
this pull request
Aug 31, 2016
…skipped always ## What changes were proposed in this pull request? Currently, `HiveContext` in SparkR is not being tested and always skipped. This is because the initiation of `TestHiveContext` is being failed due to trying to load non-existing data paths (test tables). This is introduced from #14005 This enables the tests with SparkR. ## How was this patch tested? Manually, **Before** (on Mac OS) ``` ... Skipped ------------------------------------------------------------------------ 1. create DataFrame from RDD (test_sparkSQL.R#200) - Hive is not build with SparkSQL, skipped 2. test HiveContext (test_sparkSQL.R#1041) - Hive is not build with SparkSQL, skipped 3. read/write ORC files (test_sparkSQL.R#1748) - Hive is not build with SparkSQL, skipped 4. enableHiveSupport on SparkSession (test_sparkSQL.R#2480) - Hive is not build with SparkSQL, skipped 5. sparkJars tag in SparkContext (test_Windows.R#21) - This test is only for Windows, skipped ... ``` **After** (on Mac OS) ``` ... Skipped ------------------------------------------------------------------------ 1. sparkJars tag in SparkContext (test_Windows.R#21) - This test is only for Windows, skipped ... ``` Please refer the tests below (on Windows) - Before: https://ci.appveyor.com/project/HyukjinKwon/spark/build/45-test123 - After: https://ci.appveyor.com/project/HyukjinKwon/spark/build/46-test123 Author: hyukjinkwon <gurwls223@gmail.com> Closes#14889 from HyukjinKwon/SPARK-17326.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch introduces a flag to disable loading test tables in TestHiveSparkSession and disables that in Python. This fixes an issue in which python/run-tests would fail due to failure to load test tables.
Note that these test tables are not used outside of HiveCompatibilitySuite. In the long run we should probably decouple the loading of test tables from the test Hive setup.
How was this patch tested?
This is a test only change.