Uh oh!
There was an error while loading. Please reload this page.
[SPARK-16530] [SQL] [TRIVIAL] Wrong Parser Keyword in ALTER TABLE CHANGE COLUMN - #14186
Closed
gatorsmile wants to merge 1 commit into
Closed
[SPARK-16530] [SQL] [TRIVIAL] Wrong Parser Keyword in ALTER TABLE CHANGE COLUMN#14186gatorsmile wants to merge 1 commit into
gatorsmile wants to merge 1 commit into
Conversation
hvanhovell
commented
Jul 13, 2016
Contributor
Pretty trivial :), but LGTM pending Jenkins. |
gatorsmile
commented
Jul 13, 2016
MemberAuthor
Yeah! : ) |
SparkQA
commented
Jul 13, 2016
Test build #62273 has finished for PR 14186 at commit
|
hvanhovell
commented
Jul 14, 2016
Contributor
Merging to master. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Based on the Hive SQL syntax, the command to change column name/type/position/comment is
ALTER TABLE CHANGE COLUMN. However, in our .g4 file, it isALTER TABLE CHANGE COLUMNS. Because it is the last optional keyword, it does not take any effect. Thus, I put the issue as a Trivial level.cc @hvanhovell
How was this patch tested?
Existing test cases