Skip to content

[SPARK-16538][SPARKR] fix R call with namespace operator on SparkSession functions - #14195

Closed
felixcheung wants to merge 1 commit into
apache:masterfrom
felixcheung:rroutedefault
Closed

[SPARK-16538][SPARKR] fix R call with namespace operator on SparkSession functions#14195
felixcheung wants to merge 1 commit into
apache:masterfrom
felixcheung:rroutedefault

Conversation

@felixcheung

@felixcheungfelixcheung commented Jul 14, 2016

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Fix function routing to work with and without namespace operator SparkR::createDataFrame

How was this patch tested?

manual, unit tests

@shivaram

@felixcheungfelixcheung changed the title [SPARK-16538][SPARKR] fix R call with namespace operator SparkSession functions[SPARK-16538][SPARKR] fix R call with namespace operator on SparkSession functionsJul 14, 2016
@SparkQA

SparkQA commented Jul 14, 2016

Copy link
Copy Markdown

Test build #62296 has finished for PR 14195 at commit 75193ee.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun

dongjoon-hyun commented Jul 14, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Hi, @felixcheung
LGTM. I tested it locally, too.
By the way, could you add the original reporter's testcase, too?

SparkR::sql("")

I know that it's not necessary, but it's just because the JIRA/PR looks different at the first glance.

@felixcheung

felixcheung commented Jul 14, 2016

Copy link
Copy Markdown
MemberAuthor

Thanks. That actually would fail - can't run an empty sql query.

@dongjoon-hyun

dongjoon-hyun commented Jul 14, 2016

Copy link
Copy Markdown
Member

Yep. I mean . :)

SparkR::sql("select 1")

@dongjoon-hyun

dongjoon-hyun commented Jul 14, 2016

Copy link
Copy Markdown
Member

What I wanted is SparkR::sql.

@shivaram

shivaram commented Jul 14, 2016

Copy link
Copy Markdown
Contributor

I guess it would be good to have an additional test case, but I'm going to merge this to make sure this makes 2.0 RCs. LGTM. We could look at ways to make this more robust in the future

asfgit pushed a commit that referenced this pull request Jul 14, 2016
@felixcheung@shivaram
[SPARK-16538][SPARKR] fix R call with namespace operator on SparkSess…
29281bc
…ion functions
## What changes were proposed in this pull request?
Fix function routing to work with and without namespace operator `SparkR::createDataFrame`
## How was this patch tested?
manual, unit tests
shivaram
Author: Felix Cheung <felixcheung_m@hotmail.com>
Closes#14195 from felixcheung/rroutedefault.
(cherry picked from commit 12005c8)
Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>
@dongjoon-hyun

dongjoon-hyun commented Jul 14, 2016

Copy link
Copy Markdown
Member

Great. This is in 2.0!

@felixcheungfelixcheung mentioned this pull request Jul 14, 2016
Closed
@felixcheung

felixcheung commented Jul 14, 2016

Copy link
Copy Markdown
MemberAuthor

Adding more tests in new PR. I'm hoping to remove deprecated functions and this routing mechanism as soon as 2.0.0 is released...

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felixcheung@SparkQA@dongjoon-hyun@shivaram