Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14131][SQL[STREAMING] Improved fix for avoiding potential deadlocks in HDFSMetadataLog - #14292
Closed
tdas wants to merge 4 commits into
Closed
[SPARK-14131][SQL[STREAMING] Improved fix for avoiding potential deadlocks in HDFSMetadataLog#14292tdas wants to merge 4 commits into
tdas wants to merge 4 commits into
Conversation
ContributorAuthor
SparkQA
commented
Jul 21, 2016
Test build #62645 has finished for PR 14292 at commit
|
tdas
commented
Jul 21, 2016
ContributorAuthor
test this |
SparkQA
commented
Jul 21, 2016
Test build #62644 has finished for PR 14292 at commit
|
zsxwing
commented
Jul 21, 2016
Member
@tdas this change breaks the tests as they don't run in UninterruptibleThread |
tdas
commented
Jul 21, 2016
ContributorAuthor
Fixing it. |
zsxwing
commented
Jul 21, 2016
Member
LGTM. Pending tests. |
SparkQA
commented
Jul 21, 2016
Test build #62687 has finished for PR 14292 at commit
|
SparkQA
commented
Jul 22, 2016
Test build #3189 has finished for PR 14292 at commit
|
| * potential dead-lock in Hadoop "Shell.runCommand" before 2.5.0 (HADOOP-10622). If the thread | ||
| * running "Shell.runCommand" is interrupted, then the thread can get deadlocked. In our | ||
| * case, `writeBatch` creates a file using HDFS API and calls "Shell.runCommand" to set the | ||
| * file permissions, and can get deadlocked is the stream execution thread is stopped by |
SparkQA
commented
Jul 25, 2016
Test build #62835 has finished for PR 14292 at commit
|
SparkQA
commented
Jul 25, 2016
Test build #3190 has finished for PR 14292 at commit
|
tdas
commented
Jul 25, 2016
ContributorAuthor
Tests have passed. Merging this to master and 2.0. Thanks for reviewing @zsxwing@jaceklaskowski |
asfgit pushed a commit
that referenced
this pull request
Jul 25, 2016
…locks in HDFSMetadataLog ## What changes were proposed in this pull request? Current fix for deadlock disables interrupts in the StreamExecution which getting offsets for all sources, and when writing to any metadata log, to avoid potential deadlocks in HDFSMetadataLog(see JIRA for more details). However, disabling interrupts can have unintended consequences in other sources. So I am making the fix more narrow, by disabling interrupt it only in the HDFSMetadataLog. This is a narrower fix for something risky like disabling interrupt. ## How was this patch tested? Existing tests. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes#14292 from tdas/SPARK-14131. (cherry picked from commit c979c8b) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Current fix for deadlock disables interrupts in the StreamExecution which getting offsets for all sources, and when writing to any metadata log, to avoid potential deadlocks in HDFSMetadataLog(see JIRA for more details). However, disabling interrupts can have unintended consequences in other sources. So I am making the fix more narrow, by disabling interrupt it only in the HDFSMetadataLog. This is a narrower fix for something risky like disabling interrupt.
How was this patch tested?
Existing tests.