Uh oh!
There was an error while loading. Please reload this page.
[SPARK-16715][Tests]Fix a potential ExprId conflict for SubexpressionEliminationSuite."Semantic equals and hash" - #14350
Closed
zsxwing wants to merge 1 commit into
Closed
[SPARK-16715][Tests]Fix a potential ExprId conflict for SubexpressionEliminationSuite."Semantic equals and hash"#14350zsxwing wants to merge 1 commit into
zsxwing wants to merge 1 commit into
Conversation
…mantic equals and hash" SubexpressionEliminationSuite."Semantic equals and hash" assumes the default AttributeReference's exprId wont' be "ExprId(1)". However, that depends on when this test runs. It may happen to use "ExprId(1)". This PR detects the conflict and makes sure we create a different ExprId when the conflict happens.
SparkQA
commented
Jul 25, 2016
Test build #62838 has finished for PR 14350 at commit
|
zsxwing
commented
Jul 25, 2016
MemberAuthor
/cc @yhuai |
yhuai
commented
Jul 25, 2016
Contributor
LGTM |
zsxwing
commented
Jul 25, 2016
MemberAuthor
Merging to master and 2.0. |
asfgit pushed a commit
that referenced
this pull request
Jul 25, 2016
…nEliminationSuite."Semantic equals and hash" ## What changes were proposed in this pull request? SubexpressionEliminationSuite."Semantic equals and hash" assumes the default AttributeReference's exprId wont' be "ExprId(1)". However, that depends on when this test runs. It may happen to use "ExprId(1)". This PR detects the conflict and makes sure we create a different ExprId when the conflict happens. ## How was this patch tested? Jenkins unit tests. Author: Shixiong Zhu <shixiong@databricks.com> Closes#14350 from zsxwing/SPARK-16715. (cherry picked from commit 12f490b) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SubexpressionEliminationSuite."Semantic equals and hash" assumes the default AttributeReference's exprId wont' be "ExprId(1)". However, that depends on when this test runs. It may happen to use "ExprId(1)".
This PR detects the conflict and makes sure we create a different ExprId when the conflict happens.
How was this patch tested?
Jenkins unit tests.